Fix hires buffers and showcase demos#277
Open
Vairn wants to merge 4 commits into
Open
Conversation
tehKaiN
requested changes
May 25, 2026
| if( | ||
| (pManager->ubFlags & SCROLLBUFFER_FLAG_OWN_BACK) && | ||
| pManager->pBack && pManager->pBack != pManager->pFront | ||
| pManager->pBack && (!isOwnFront || pManager->pBack != pManager->pFront) |
Member
There was a problem hiding this comment.
this code is a bit cryptic here - just checking for OWN_BACK and non-same buffers should be enough
| g_pCustom->bplcon3 = 0; // AGA fix | ||
| #endif | ||
| if(pView->pFirstVPort->eFlags & VP_FLAG_HIRES) { | ||
| g_pCustom->bplcon0 |= BV(15); |
Member
There was a problem hiding this comment.
this won't work, bplcon0 is write-only
| tCopBlock *pBlock = pManager->pCopBlock; | ||
| pBlock->uwCurrCount = 0; // Rewind to beginning | ||
| if(ubHiresCop) { | ||
| copMove( |
Member
There was a problem hiding this comment.
I don't like conditional length of the copperlist when the fn for getting cop length isn't conditional.
Also, why's that only for simplebuffer and only for block mode?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Hires screen issues, as shown in showcase.
Attempted to fix Reusable Buffer example, couldn't replicate but tightened up the demo.
Checklist