Fix regression from commit b8595d7 (#5043)#284
Open
jkanefendt wants to merge 2 commits into
Open
Conversation
…into contact entry dicts in [LDAPSource membersForGroupWithUID]
|
I don't know that this is the right place to ask this question?? I want to install SOGo on Docker or docker-compose.yml. Is there any docker run command or docker-compose file available? I have seen some SOGo docker images. But I need the official one. |
Contributor
|
@arunodhayam10d You should use the mailing list for such question. |
WoodySlum
force-pushed
the
master
branch
2 times, most recently
from
e4c98fd to
2258d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit b8595d7 partially reverts commit 278d4ab. It is breaking the contract of [SOGoMembershipSource groupWithUIDHasMemberWithUID] to return an array of contact dicts and thus our custom user source implementation.
This PR reverts b8595d7. Instead of that, instances of SOGoUser are turned into contact entry dicts in [LDAPSource membersForGroupWithUID].