TPC: Add CMV processing #15283
Conversation
ehellbar
left a comment
There was a problem hiding this comment.
please also add the formatting suggestions by the format checker.
|
you picked up a lot of commits in your latest push. Can you clean it up or rebase it properly, please? :) |
| add_W o2-tpc-idc-ft-aggregator "--rangeIDC 200 --inputLanes ${lanesFactorize} --nFourierCoeff 40 --nthreads 8" | ||
| fi | ||
| if [[ $CALIB_TPC_CMV == 1 ]] && [[ $AGGREGATOR_TASKS == TPC_IDCBOTH_SAC || $AGGREGATOR_TASKS == ALL ]]; then | ||
| if [[ -z ${O2_TPC_CMV_COMPRESSION:-} ]]; then O2_TPC_CMV_DYNAMIC_PRECISION_MEAN="--cmv-zero-threshold 1.0 --cmv-dynamic-precision-mean 1.0--cmv-dynamic-precision-sigma 8.0 --use-compression-huffman"; fi |
There was a problem hiding this comment.
there's a leftover from your changes. You define O2_TPC_CMV_DYNAMIC_PRECISION_MEAN but check for and later use O2_TPC_CMV_COMPRESSION
|
Error while checking build/O2/fullCI_slc9 for d7bccc5 at 2026-04-24 18:25: Full log here. |
|
Error while checking build/O2/fullCI_slc9 for a2bb660 at 2026-04-24 18:47: Full log here. |
|
@rmunzer I suggest to leave this open until the tests at P2 with these workflows converge |
|
Error while checking build/O2/fullCI_slc9 for 51f3bc5 at 2026-04-28 18:07: Full log here. |
…ctor adding of IDC workflows
don't add ccdb-populator if not needed for IDC calib collection; refactor adding of IDC workflows
|
the errors in the failing test are unrelated to this, merging |
No description provided.