Repository navigation
Conversation
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
thank you for the pr. I have been intending to do this, and also to go through and find non-working sources that have not been reported, but I haven't found the time yet.
however, can you also update the aidoku package dependency for all sources? this will fix some of the bail macro usages automatically without needing other changes, and will fix potential issues like this, according to skitty. source versions can be kept as-is.
| _ => { | ||
| bail!("Invalid listing"); | ||
| } |
There was a problem hiding this comment.
changes like this shouldn't be necessary if aidoku-rs is updated: Aidoku/aidoku-rs#38.
|
i will do the manual upgrade for all sources, then undo the however, i'd also like you to consider maybe transitioning this repo from individual cargo projects into a workspace with all its crates. i know the aidoku-rs cli doesn't support it at all and prefers individual crates, but for a repo containing multiple sources a workspace fits it so well. it would give you access to shared dependencies, of which you can ensure all sources are on the same revision and are easily upgradeable, and also reduce compile time for building more than 1 crate since dependencies can be reused across sources (especially common ones like aidoku-rs and serde). clippy checks would be much faster too |
This branch has not been deployed
2 participants
the build workflows for this repo don't pin the rustc versions. after this recent actions run using rustc v1.99.0 a bunch of sources started emitting warnings that will eventually turn to errors. this pr fixed those warnings (most of them are the macro changes with
;, see rust-lang/rust#79813), ran a lint + format over affected files, then pinned the CI versions to rust toolchain v1.99.0 (one used in that CI run). if you don't like the ci rustc version pinning feel free to remove it and just keep the fixes.