Repository navigation
fix(ru.desu): improve Ranobe chapter and catalog support - #802
Conversation
Switch Ranobe chapter discovery to the JSON API while keeping legacy URL keys and deep links resolvable. Preserve existing details during chapter-only refreshes, parse ordered text/image blocks safely, and add confirmed Ranobe metadata and catalog filters. Update source version and maintainer documentation.
kkantan
left a comment
There was a problem hiding this comment.
can you run cargo update to update the aidoku-rs dependency?
| qs.push("page", Some(page.to_string().as_str())); | ||
| if let Some(q) = query.filter(|s| !s.is_empty()) { | ||
| qs.push("search", Some(q.as_str())); | ||
| if let Some(query) = query.filter(|query| !query.is_empty()) { |
There was a problem hiding this comment.
the query should never be empty, so this check isn't necessary. you're also unwrapping and rewrapping the query. you could simply check if query.is_some() then qs.push("search", query).
There was a problem hiding this comment.
Updated in 3f2a918. cargo update -p aidoku advanced both aidoku and aidoku-test to ae6485e3; only their shared git revision changed in Cargo.lock. I simplified optional query handling after confirming the Aidoku v0.9 bridge turns empty input into None. Local checks pass: fmt, 25 WASM tests, Clippy (-D warnings), check, package, verify, and archive integrity. GitHub Actions are running now.
Review follow-upApplied in commit
Local verification passed: |
Summary
Validation
cargo fmt --checkcargo test --target wasm32-unknown-unknown(25 tests)cargo clippy --target wasm32-unknown-unknown -- -D warningscargo check --target wasm32-unknown-unknownaidoku package,aidoku verify, andunzip -t