This PR sets up the CI/CD pipelines,Adds comprehensive unit tests for the Analyser and Plate Girder Validator, and resolves a critical bug in the validator that was causing test failures. - #306
Open
ManavSharma23 wants to merge 1 commit into
Conversation
Includes: - Add GitHub Actions CI workflow (.github/workflows/ci.yml) - Add pytest-cov dependency in pyproject.toml - Add unit tests for analyser and plate girder validator - Fix transverse spacing validator to convert top flange width from meters to mm - Add pytest configuration in tools/conftest.py
|
@ManavSharma23 This single commit is doing lots of work, maybe you can reset your branch add test specific files in in staging then make a commit for test, and then same for CI and update in pyproject.toml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD Pipeline
GitHub Actions Workflow (.github/workflows/ci.yml): Configured an automated workflow to run code linting (ruff), type checking (mypy), and unit tests (pytest) on every push and pull request.
Codecov Integration: Integrated Codecov coverage reports. Quality check and report upload steps are configured as non-blocking (continue-on-error: true) to prevent CI failures in forks lacking repository-specific secrets.
Dependency Update (pyproject.toml): Added pytest-cov to developer dependencies.
Unit Tests
Analyser Tests (tests/unit/test_analyser.py): Implemented tests to verify plate girder structure calculations, forces, and moments under different support conditions.
Plate Girder Validator Tests (tests/unit/test_plategirder_validator.py): Implemented tests to validate rules for girder dimensions, spacing, web thickness, and flange dimensions.
Test Configuration (tools/conftest.py): Configured testing environment defaults.
Bug Fixes
Transverse Spacing Validator (src/osdagbridge/core/bridge_types/plate_girder/validator.py):
Fixed a bug where the top flange width was not converted from meters to millimeters in the spacing check logic.
This scaling mismatch caused incorrect validation failures.