Skip to content

Fix pyconfig access regression in inference_microbenchmark_sweep#4540

Open
patemotter wants to merge 1 commit into
mainfrom
patemotter/inf-benchmark-fix
Open

Fix pyconfig access regression in inference_microbenchmark_sweep#4540
patemotter wants to merge 1 commit into
mainfrom
patemotter/inf-benchmark-fix

Conversation

@patemotter

@patemotter patemotter commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Replaces private pyconfig._config.keys mutation with pyconfig.initialize kwargs overrides per sweep iteration. Use public config.get_keys() for metadata serialization.

Fixes b/529187555

Tests

Local build

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant