(ios) Fix Send footer clipping with large Dynamic Type#814
Open
Vidarte-Alberto wants to merge 1 commit into
Open
(ios) Fix Send footer clipping with large Dynamic Type#814Vidarte-Alberto wants to merge 1 commit into
Vidarte-Alberto wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the user has an accessibility font size enabled, the four action buttons in the Send screen footer (
paste,choose image,nfc,scan qr code) overflow their container. Because the caption labels scale with Dynamic Type,maxButtonWidthgrows large enough that the total width of the four buttons exceeds the screen width.The
ViewThatFitsfallback does not catch this correctly: it measures the layout during a first pass whenmaxButtonWidthis stillnil, commits tofooter_standard(), and then overflows silently after theGeometryPreferenceReaderupdates the value. As a result, the leftmost and rightmost buttons are clipped off-screen.Screenshots
Fix
Detected the accessibility font size via
@Environment(\.dynamicTypeSize). WhenisAccessibilitySizeistrue, theViewThatFitslayout is replaced with a horizontalScrollView.The scroll variant uses the exact same round buttons and
maxButtonWidthequal-width logic — it is purely a layout change. For all non-accessibility font sizes, the standard behavior remains completely unchanged.How to Test