Skip to content

Fix CaveGenMixin not preserving vanilla behavior#862

Merged
ACGaming merged 1 commit into
ACGaming:mainfrom
inboundbark:cave-fix
May 25, 2026
Merged

Fix CaveGenMixin not preserving vanilla behavior#862
ACGaming merged 1 commit into
ACGaming:mainfrom
inboundbark:cave-fix

Conversation

@inboundbark

Copy link
Copy Markdown
Contributor

Enabling the cave generation toggle made caves spawn differently from vanilla even without changing values from their vanilla defaults. It also didn't replicate r1.6 caves when changing the size to 40 and rarity to 15.

This should make cave generation identical to 1.6 when values 40 and 15
are used
@what-the-diff

what-the-diff Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

  • Refined Code Modification
    Switched from utilizing the ModifyArg to ModifyExpressionValue in the import statement. This step offers a more accurate way of modifying the code.

  • Cave Generation Size Update
    The utCaveGenSize function, that determines the size of caves, has been improved. Previously, it was taking variable values but now, it has been modified to use fixed values for size generation, which makes the output more consistent.

  • Cave Generation Rarity Upgrade
    Similar changes have been made to utCaveGenRarity, a method that governs the rarity of cave generation. This function has also been updated to use a set value, also known as a 'constant', rather than a variable.

  • Enhanced Clarity and Maintainability
    These changes to the two methods increase the clarity of our code and make it easier to maintain over time. Utilizing constants for value injection instead of method calls simplifies the understanding of what each piece of code does.

@ACGaming ACGaming merged commit 3014d40 into ACGaming:main May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants