feat(operator): DVT node-registration wizard (CC-17 / aastar-sdk#279)

[jhfnetboy]

What

Guided operator onboarding for DVT signing-node registration — turns the manual registerWithProof script into a 5-step wizard under app/operator/dvt-register/.

Flow: connect → eligibility → key & PoP → register → done. Reuses the existing operator deploy-wizard scaffolding (StepCard / WizardButton / WizardProgress / FormField / useTxStep) and the Track-C browser-signing path (operator's own EOA signs; no backend key).

Highlights

• Eligibility short-circuit: operatorNode(operator) non-zero → jump to done showing the bound nodeId.
• BLS key stays local: generated (crypto.getRandomValues) or imported in-browser, held only in in-memory wizard state — never persisted, never sent to the backend. Red warning + offline-backup prompt. nodeId previewed from the PoP before any tx.
• SDK boundary in one file (lib/sdk/dvtOperator.ts): all chain/crypto calls funnel through it.

SDK wiring

@aastar/sdk 0.38.0 shipped buildDvtPop + dvtOperatorActions (aastar-sdk#288, E2E LIVE PASS on Sepolia). Wiring = flip DVT_SDK_READY, add the import, fill the WIRE-HERE bodies. (Done in a follow-up commit on this branch.)

Test

• type-check + eslint green.

Coordination: CC-17.

https://claude.ai/code/session_01RajETCvboSvhadpqMbekNx

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[clestons]

#424 — APPROVE

PK: 1 round (Codex) · 2 confirmed · 1 challenged (F3 rejected) · 1 MISSED (Low) · head 9c3aeee7

DVT 节点注册向导结构清晰，BLS 私钥全程仅驻留浏览器内存，未持久化也未传后端。DVT_SDK_READY 机制保证 0.38.0 前 UI 可走完但链上步骤被明确 stub，二次 commit 的 wiring 也正确：readActions() 用 getPublicClient() 读，writeActions(walletClient) 用 operator 钱包写。

---

[Confirmed, Medium] F1 — generateBlsSecretKey() 约 55% 生成无效密钥，注释严重错误

lib/sdk/dvtOperator.ts:86-95

BLS12-381 标量域阶 r = 0x73eda753…，约 0.45 × 2^256，因此均匀随机 256-bit 值超过 r 的概率约 55%。每次点"生成新密钥"约每隔一次 buildDvtPop 就会抛出 invalid BLS secret key: out of range，用户看到错误并需要重试。注释声称 "~2^-128 chance" 系错误估算，实际差了约 2^127 倍。

建议在生成循环内拒绝越界值：

export function generateBlsSecretKey(): Hex {
  while (true) {
    const bytes = new Uint8Array(32);
    crypto.getRandomValues(bytes);
    const hex = Array.from(bytes, b => b.toString(16).padStart(2, "0")).join("");
    const key = `0x${hex}` as Hex;
    try { buildDvtPop(key); return key; } catch { /* out of range, retry */ }
  }
}

或直接用 BigInt(rand) % r + 1n 生成均匀标量。

---

[Confirmed, Low] F2 — isDvtNodeRegistered 返回值未检查，注册失败可能被静默吞掉

aastar-frontend/app/operator/dvt-register/steps/Step4Register.tsx:52-58

try {
  if (nodeId) await isDvtNodeRegistered(walletClient, nodeId);  // bool 被丢弃
} catch (err) {
  setConfirmError(...)
}
onNext();  // 无论 isRegistered 是否为 true

若 isRegistered 返回 false（链上确认延迟或 RPC 抖动），向导静默前进到 "Registration complete"，实际节点未注册。建议：

const isReg = await isDvtNodeRegistered(walletClient, nodeId);
if (!isReg) setConfirmError("Node ID not yet visible on-chain — please refresh eligibility.");

---

[PK-added, Low] M1 — applyKey 在 buildDvtPop 抛错后仍将无效 key 写入 wizard state

aastar-frontend/app/operator/dvt-register/steps/Step3KeyPoP.tsx:46-53

const applyKey = (secret: Hex) => {
  setError(undefined);
  let pop: DvtPop | undefined;
  if (DVT_SDK_READY) {
    try {
      pop = buildDvtPop(secret);
    } catch (err) {
      setError(...);
      // ← 没有 return
    }
  }
  update({ blsSecretKey: secret, pop });  // 越界 key 也被写入
};

buildDvtPop 抛出时 pop = undefined 但 blsSecretKey = secret 被写入。hasKey = !!data.blsSecretKey 为 true → Continue 按钮可用，用户可带无效 key 进入 Step4，Step4 的 register 调用会再次失败。建议 catch 内 return，不调用 update()。

---

Rejected

• F3（fetchDvtEligibility 参数名变更为非下划线）：diff 中实际未发生重命名，_walletClient 依然保留，系审查侧误读。

---

PK Summary

Finding	Verdict
F1 generateBlsSecretKey ~55% 越界	[CONFIRM] Medium
F2 isDvtNodeRegistered bool 被丢弃	[CONFIRM] Low
F3 参数名重命名误读	Rejected
M1 applyKey 越界 key 写入 state	[PK-added] Low

APPROVE

[clestons]

#424 — APPROVE（增量）

增量 scope：9c3aeee7..d99a5af1（1 commit: fix 上轮 review）
PK: 1 round · 3 confirmed · 0 challenged · 0 MISSED · head d99a5af1

上轮三个 findings 均已正确修复：

• F1 generateBlsSecretKey 改用 rejection-sampling，BLS12_381_R 常量正确，循环边界 [1, r-1] 无误，注释更新为"~2 draws on average"。✓
• F2 isDvtNodeRegistered 返回值已检查，false 时触发 confirmFailed i18n 提示（EN/ZH 均已添加），onNext() 仍调用（tx 已确认，设计正确）。✓
• M1 applyKey 成功路径才持久化 key + pop；失败路径同步清空两者，无效 key 不再使 Continue 按钮可用。✓

APPROVE