Repository navigation
docs: correct BLE v7 manufacturer data layout, remove dead v7 parser - #123
Merged
Merged
Conversation
…119) 02_manufacturer_data.md put v7 power at state_data[11]; the issue #119 capture shows it is the first state byte. Add the 14-byte service data form and the v7 state array with the real capture, note what is still unverified, log the correction in DISCOVERIES.md, and remove parse_v7_with_service_data, which was written to the wrong layout and had no callers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #119 / #120.
protocol_docs/02_manufacturer_data.mdsaid v7 power isstate_data[11](mfr_data[14]). The #119 capture has power as the first state byte (data[1]). The unusedparse_v7_with_service_datawas written to the same wrong layout.Changes:
data[1:26]in Bleak terms, checked againstZGHBDevice.java), fix the code sample and key points, list what is still unverified.DISCOVERIES.md: correction entry.protocol.py: removeparse_v7_with_service_data. A grep finds no callers.No behaviour change. Tests: 45 passed.
🤖 Generated with Claude Code