-
Notifications
You must be signed in to change notification settings - Fork 119
Validator block backup #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sergerad
merged 6 commits into
sergerad-validator-modules
from
sergerad-validator-block-bkp
Jun 11, 2026
Merged
Validator block backup #2232
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
de6423e
Validator block backup
sergerad e184f6b
Treat backup failure as non fatal
sergerad 4cac17d
Add blocks subdir
sergerad 49c3e16
Fix dir
sergerad 9ae9d5e
Merge branch 'sergerad-validator-modules' of github.com:0xMiden/miden…
sergerad 2301fc2
Error out on backup
sergerad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mirko-von-Leipzig I was wondering if we should use the store crate's
DataDirectorystruct for this but there is a discrepancy between the db filepaths atm (validator.sqlite3 vs miden-store.sqlite3).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been wondering if we can't clean things up somehow.. At the moment its not quite an easy split, so maybe what you've got here is fine and we shouldn't force coupling between things that aren't literally the same thing.
We could mimic the struct here with the differences? Or create the struct with a configurable service name e.g.
nodeandvalidatorwhich would be used to infer the sqlite3 filestem?But I think lets keep them separate 🤷 They want to store different things over time so maybe its best to keep them decoupled.