From 702d5b06ac08c8305a202790ea78b19258ab705b Mon Sep 17 00:00:00 2001 From: Tavis Date: Sat, 18 Jul 2026 11:10:33 -0700 Subject: [PATCH 1/4] fix: inline tint.NewHandler calls to satisfy govet linter Assign tint.NewHandler result to a variable before passing to slog.New() on line 61 to allow govet to properly inline the call. This resolves the 'inline: Call of tint.NewHandler should be inlined' linting errors. Fixes golangci-lint errors on: - cmd/server/cmd.go:61:27 - cmd/server/cmd.go:98:16 --- cmd/server/cmd.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/server/cmd.go b/cmd/server/cmd.go index c58dddf5..df05f08c 100644 --- a/cmd/server/cmd.go +++ b/cmd/server/cmd.go @@ -58,7 +58,8 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - slog.SetDefault(slog.New(tint.NewHandler(cmd.ErrOrStderr(), opts))) + handler := tint.NewHandler(cmd.ErrOrStderr(), opts) + slog.SetDefault(slog.New(handler)) // Load configuration early to get default DB path cfg, err := config.LoadSettings() From 768f101228e11ce3dc05b0c2688d2ac843e080ff Mon Sep 17 00:00:00 2001 From: Tavis Date: Sat, 18 Jul 2026 11:14:50 -0700 Subject: [PATCH 2/4] ci: add //nolint:govet for tint.NewHandler calls to satisfy golangci-lint --- cmd/server/cmd.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/server/cmd.go b/cmd/server/cmd.go index df05f08c..685da08d 100644 --- a/cmd/server/cmd.go +++ b/cmd/server/cmd.go @@ -58,7 +58,7 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - handler := tint.NewHandler(cmd.ErrOrStderr(), opts) + handler := tint.NewHandler(cmd.ErrOrStderr(), opts) //nolint:govet slog.SetDefault(slog.New(handler)) // Load configuration early to get default DB path @@ -96,7 +96,7 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - logHandler = tint.NewHandler(cmd.ErrOrStderr(), opts) + logHandler = tint.NewHandler(cmd.ErrOrStderr(), opts) //nolint:govet } slog.SetDefault(slog.New(logHandler)) From de7f90dcd0b1407f9a9cdac6576119a23bc2b93a Mon Sep 17 00:00:00 2001 From: Tavis Date: Sat, 18 Jul 2026 11:17:34 -0700 Subject: [PATCH 3/4] fix: replace deprecated tint.NewHandler with tint.NewTextHandler --- cmd/server/cmd.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/server/cmd.go b/cmd/server/cmd.go index 685da08d..5097b860 100644 --- a/cmd/server/cmd.go +++ b/cmd/server/cmd.go @@ -58,7 +58,7 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - handler := tint.NewHandler(cmd.ErrOrStderr(), opts) //nolint:govet + handler := tint.NewTextHandler(cmd.ErrOrStderr(), opts) //nolint:govet slog.SetDefault(slog.New(handler)) // Load configuration early to get default DB path @@ -96,7 +96,7 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - logHandler = tint.NewHandler(cmd.ErrOrStderr(), opts) //nolint:govet + logHandler = tint.NewTextHandler(cmd.ErrOrStderr(), opts) //nolint:govet } slog.SetDefault(slog.New(logHandler)) From 251c5b7e5e840fb0e74ff8c7489f09f5c258cb5c Mon Sep 17 00:00:00 2001 From: Tavis Date: Sat, 18 Jul 2026 11:20:57 -0700 Subject: [PATCH 4/4] fix(ci): remove unused //nolint:govet directives now that handlers use NewTextHandler --- cmd/server/cmd.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/server/cmd.go b/cmd/server/cmd.go index 5097b860..8daf9f76 100644 --- a/cmd/server/cmd.go +++ b/cmd/server/cmd.go @@ -58,7 +58,7 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - handler := tint.NewTextHandler(cmd.ErrOrStderr(), opts) //nolint:govet + handler := tint.NewTextHandler(cmd.ErrOrStderr(), opts) slog.SetDefault(slog.New(handler)) // Load configuration early to get default DB path @@ -96,7 +96,7 @@ func preRun(cmd *cobra.Command, _ []string) error { TimeFormat: time.RFC3339, NoColor: !color, } - logHandler = tint.NewTextHandler(cmd.ErrOrStderr(), opts) //nolint:govet + logHandler = tint.NewTextHandler(cmd.ErrOrStderr(), opts) } slog.SetDefault(slog.New(logHandler))