|
| 1 | +use anyhow::{Context, Result}; |
| 2 | +use serde_json::Value; |
| 3 | +use std::process::Command; |
| 4 | + |
| 5 | +mod support; |
| 6 | +use support::cli_test_env::apply_hermetic_env; |
| 7 | + |
| 8 | +fn run_agent(args: &[&str]) -> Result<(String, String, i32)> { |
| 9 | + let mut cmd = Command::new(env!("CARGO_BIN_EXE_terraphim-agent")); |
| 10 | + cmd.args(args); |
| 11 | + apply_hermetic_env(&mut cmd)?; |
| 12 | + |
| 13 | + let output = cmd.output().context("run terraphim-agent")?; |
| 14 | + |
| 15 | + Ok(( |
| 16 | + String::from_utf8_lossy(&output.stdout).to_string(), |
| 17 | + String::from_utf8_lossy(&output.stderr).to_string(), |
| 18 | + output.status.code().unwrap_or(-1), |
| 19 | + )) |
| 20 | +} |
| 21 | + |
| 22 | +#[test] |
| 23 | +fn global_json_compact_guard_emits_single_line_json() -> Result<()> { |
| 24 | + let (stdout, stderr, code) = |
| 25 | + run_agent(&["--format", "json-compact", "guard", "git reset --hard HEAD"])?; |
| 26 | + |
| 27 | + assert_eq!( |
| 28 | + code, 0, |
| 29 | + "machine-readable guard should preserve --json compatibility; stderr={stderr}" |
| 30 | + ); |
| 31 | + assert!( |
| 32 | + !stderr.contains("BLOCKED:"), |
| 33 | + "human BLOCKED text must not be emitted for global JSON format: {stderr}" |
| 34 | + ); |
| 35 | + |
| 36 | + let trimmed = stdout.trim(); |
| 37 | + assert!(!trimmed.is_empty(), "stdout should contain JSON"); |
| 38 | + assert_eq!( |
| 39 | + trimmed.lines().count(), |
| 40 | + 1, |
| 41 | + "json-compact should be single-line" |
| 42 | + ); |
| 43 | + let json: Value = serde_json::from_str(trimmed)?; |
| 44 | + assert_eq!(json["decision"], "block"); |
| 45 | + assert_eq!(json["command"], "git reset --hard HEAD"); |
| 46 | + Ok(()) |
| 47 | +} |
| 48 | + |
| 49 | +#[test] |
| 50 | +fn global_json_validate_emits_parseable_json() -> Result<()> { |
| 51 | + let (stdout, stderr, code) = run_agent(&["--format", "json", "validate", "terraphim"])?; |
| 52 | + |
| 53 | + assert_eq!(code, 0, "validate should succeed; stderr={stderr}"); |
| 54 | + let json: Value = serde_json::from_str(stdout.trim())?; |
| 55 | + assert!( |
| 56 | + json.get("matched_count").is_some() || json.get("error").is_some(), |
| 57 | + "unexpected validate JSON: {json}" |
| 58 | + ); |
| 59 | + Ok(()) |
| 60 | +} |
| 61 | + |
| 62 | +#[test] |
| 63 | +fn global_json_guard_emits_pretty_json() -> Result<()> { |
| 64 | + let (stdout, stderr, code) = |
| 65 | + run_agent(&["--format", "json", "guard", "git reset --hard HEAD"])?; |
| 66 | + |
| 67 | + assert_eq!( |
| 68 | + code, 0, |
| 69 | + "global --format json guard should succeed; stderr={stderr}" |
| 70 | + ); |
| 71 | + assert!( |
| 72 | + !stderr.contains("BLOCKED:"), |
| 73 | + "human BLOCKED text must not be emitted for global JSON format: {stderr}" |
| 74 | + ); |
| 75 | + let json = assert_pretty_json(&stdout)?; |
| 76 | + assert_eq!(json["decision"], "block"); |
| 77 | + assert_eq!(json["command"], "git reset --hard HEAD"); |
| 78 | + Ok(()) |
| 79 | +} |
| 80 | + |
| 81 | +#[test] |
| 82 | +fn global_json_compact_suggest_emits_parseable_json() -> Result<()> { |
| 83 | + let (stdout, stderr, code) = run_agent(&[ |
| 84 | + "--format", |
| 85 | + "json-compact", |
| 86 | + "suggest", |
| 87 | + "terraphim", |
| 88 | + "--limit", |
| 89 | + "3", |
| 90 | + ])?; |
| 91 | + |
| 92 | + assert_eq!(code, 0, "suggest should succeed; stderr={stderr}"); |
| 93 | + assert_single_line_json(&stdout)?; |
| 94 | + Ok(()) |
| 95 | +} |
| 96 | + |
| 97 | +#[test] |
| 98 | +fn legacy_guard_json_stays_single_line_compact() -> Result<()> { |
| 99 | + let (stdout, stderr, code) = run_agent(&["guard", "--json", "git reset --hard HEAD"])?; |
| 100 | + |
| 101 | + assert_eq!( |
| 102 | + code, 0, |
| 103 | + "legacy guard --json compatibility; stderr={stderr}" |
| 104 | + ); |
| 105 | + assert!( |
| 106 | + !stderr.contains("BLOCKED:"), |
| 107 | + "legacy JSON guard should not emit human BLOCKED text: {stderr}" |
| 108 | + ); |
| 109 | + let json = assert_single_line_json(&stdout)?; |
| 110 | + assert_eq!(json["decision"], "block"); |
| 111 | + Ok(()) |
| 112 | +} |
| 113 | + |
| 114 | +#[test] |
| 115 | +fn legacy_validate_json_stays_single_line_compact() -> Result<()> { |
| 116 | + let (stdout, stderr, code) = run_agent(&["validate", "--json", "terraphim"])?; |
| 117 | + |
| 118 | + assert_eq!( |
| 119 | + code, 0, |
| 120 | + "legacy validate --json compatibility; stderr={stderr}" |
| 121 | + ); |
| 122 | + let json = assert_single_line_json(&stdout)?; |
| 123 | + assert!( |
| 124 | + json.get("matched_count").is_some() || json.get("error").is_some(), |
| 125 | + "unexpected validate JSON: {json}" |
| 126 | + ); |
| 127 | + Ok(()) |
| 128 | +} |
| 129 | + |
| 130 | +#[test] |
| 131 | +fn legacy_suggest_json_stays_single_line_compact() -> Result<()> { |
| 132 | + let (stdout, stderr, code) = run_agent(&["suggest", "--json", "terraphim", "--limit", "3"])?; |
| 133 | + |
| 134 | + assert_eq!( |
| 135 | + code, 0, |
| 136 | + "legacy suggest --json compatibility; stderr={stderr}" |
| 137 | + ); |
| 138 | + assert_single_line_json(&stdout)?; |
| 139 | + Ok(()) |
| 140 | +} |
| 141 | + |
| 142 | +#[test] |
| 143 | +fn server_mode_global_json_compact_guard_emits_single_line_json() -> Result<()> { |
| 144 | + let (stdout, stderr, code) = run_agent(&[ |
| 145 | + "--server", |
| 146 | + "--format", |
| 147 | + "json-compact", |
| 148 | + "guard", |
| 149 | + "git reset --hard HEAD", |
| 150 | + ])?; |
| 151 | + |
| 152 | + assert_eq!( |
| 153 | + code, 0, |
| 154 | + "machine-readable server-mode guard should preserve --json compatibility; stderr={stderr}" |
| 155 | + ); |
| 156 | + assert!( |
| 157 | + !stderr.contains("BLOCKED:"), |
| 158 | + "human BLOCKED text must not be emitted for server-mode global JSON format: {stderr}" |
| 159 | + ); |
| 160 | + let json = assert_single_line_json(&stdout)?; |
| 161 | + assert_eq!(json["decision"], "block"); |
| 162 | + Ok(()) |
| 163 | +} |
| 164 | + |
| 165 | +#[test] |
| 166 | +fn server_mode_global_json_validate_error_is_parseable_json() -> Result<()> { |
| 167 | + let (stdout, stderr, code) = run_agent(&[ |
| 168 | + "--server", |
| 169 | + "--format", |
| 170 | + "json-compact", |
| 171 | + "validate", |
| 172 | + "terraphim", |
| 173 | + ])?; |
| 174 | + |
| 175 | + assert_eq!(code, 1, "server-mode validate should remain unavailable"); |
| 176 | + assert!( |
| 177 | + !stderr.contains("Validate command is only available in offline mode"), |
| 178 | + "machine-readable unavailable error must be stdout JSON, not human stderr: {stderr}" |
| 179 | + ); |
| 180 | + let json = assert_single_line_json(&stdout)?; |
| 181 | + assert_eq!( |
| 182 | + json["error"], |
| 183 | + "Validate command is only available in offline mode" |
| 184 | + ); |
| 185 | + Ok(()) |
| 186 | +} |
| 187 | + |
| 188 | +#[test] |
| 189 | +fn server_mode_global_json_compact_suggest_error_is_parseable_json() -> Result<()> { |
| 190 | + let (stdout, stderr, code) = run_agent(&[ |
| 191 | + "--server", |
| 192 | + "--format", |
| 193 | + "json-compact", |
| 194 | + "suggest", |
| 195 | + "terraphim", |
| 196 | + "--limit", |
| 197 | + "3", |
| 198 | + ])?; |
| 199 | + |
| 200 | + assert_eq!(code, 1, "server-mode suggest should remain unavailable"); |
| 201 | + assert!( |
| 202 | + !stderr.contains("Suggest command is only available in offline mode"), |
| 203 | + "machine-readable unavailable error must be stdout JSON, not human stderr: {stderr}" |
| 204 | + ); |
| 205 | + let json = assert_single_line_json(&stdout)?; |
| 206 | + assert_eq!( |
| 207 | + json["error"], |
| 208 | + "Suggest command is only available in offline mode" |
| 209 | + ); |
| 210 | + Ok(()) |
| 211 | +} |
| 212 | + |
| 213 | +fn assert_single_line_json(stdout: &str) -> Result<Value> { |
| 214 | + let trimmed = stdout.trim(); |
| 215 | + assert!(!trimmed.is_empty(), "stdout should contain JSON"); |
| 216 | + assert_eq!( |
| 217 | + trimmed.lines().count(), |
| 218 | + 1, |
| 219 | + "json-compact should be single-line" |
| 220 | + ); |
| 221 | + Ok(serde_json::from_str(trimmed)?) |
| 222 | +} |
| 223 | + |
| 224 | +fn assert_pretty_json(stdout: &str) -> Result<Value> { |
| 225 | + let trimmed = stdout.trim(); |
| 226 | + assert!(!trimmed.is_empty(), "stdout should contain JSON"); |
| 227 | + assert!( |
| 228 | + trimmed.lines().count() > 1, |
| 229 | + "--format json should be pretty multi-line JSON; stdout={trimmed}" |
| 230 | + ); |
| 231 | + Ok(serde_json::from_str(trimmed)?) |
| 232 | +} |
0 commit comments