fix: treat SQL Server setup exit code 3010 as success

Setup exits with 3010 when it succeeds but wants a reboot, which a
runner can't do mid-job. Previously @actions/exec rejected that as a
failure even though the instance was installed. Log a warning instead
and continue, letting the wait-for-ready check confirm the instance is
usable. Any other non-zero exit code still fails the action.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: dhensby

.github/copilot-instructions.md

@@ -47,7 +47,7 @@ The build step (`npm run build`) also runs `npm run docs`, which regenerates the
 3. Optionally installs SQL Native Client (`src/install-native-client.ts`) and ODBC driver (`src/install-odbc.ts`)
 4. Downloads or cache-hits the SQL Server installer (box+exe, standalone exe, or SSEI bootstrapper)
 5. Optionally downloads cumulative updates (resolves Microsoft download-page JSON, falls back to legacy links if metadata is unusable, retries network errors, timeouts and all non-2xx page responses up to three times with 5- and 10-second delays, and warns then installs without updates if the download fails)
-6. Runs the installer via `@actions/exec`
+6. Runs the installer via `@actions/exec` (exit code 3010, "succeeded but reboot required", is logged as a warning and treated as success; any other non-zero code fails the action)
 7. Waits for the database to be ready (exponential backoff)
 
 **Installer abstraction:** `src/installers/` contains a base `Installer` class and `MsiInstaller` subclass used by the native client and ODBC installations. SQL Server itself uses direct exe/box download logic or the SSEI bootstrapper (for 2025+) in `src/utils.ts`.

README.md

@@ -73,6 +73,12 @@ reason and installs SQL Server without updates. Update URLs are configured for
 SQL Server 2016 and later, including 2025 (and so the default, `'latest'`);
 older versions skip updates.
 
+### Reboot requests
+
+If SQL Server setup succeeds but asks for a reboot (exit code 3010), the action
+logs a warning and carries on without rebooting. The wait-for-ready check (when
+`wait-for-ready` is enabled) then confirms the instance is accepting queries.
+
 ### Basic usage
 
 ```yml

lib/main/index.js

@@ -120,7 +120,7 @@ export default async function install() {
     const instanceName = 'MSSQLSERVER';
     try {
         // @todo - make sure that the arguments are unique / don't conflict
-        await core.group('Installing SQL Server', () => exec.exec(`"${toolPath}"`, [
+        const exitCode = await core.group('Installing SQL Server', () => exec.exec(`"${toolPath}"`, [
             '/q',
             '/ACTION=Install',
             '/FEATURES=SQLEngine', //,FullText,RS,Tools
@@ -137,7 +137,15 @@ export default async function install() {
             ...installArgs,
         ], {
             windowsVerbatimArguments: true,
+            ignoreReturnCode: true,
         }));
+        // 3010 means setup succeeded but requested a reboot, which isn't possible mid-job. Carry on
+        // and let the readiness check confirm the instance is usable.
+        if (exitCode === 3010) {
+            core.warning('SQL Server setup succeeded but requested a reboot (exit code 3010); continuing without rebooting');
+        } else if (exitCode !== 0) {
+            throw new Error(`SQL Server setup failed with exit code ${exitCode}`);
+        }
         // set outputs
         core.setOutput('sa-password', password);
         core.setOutput('instance-name', instanceName);

lib/main/index.js.map

@@ -146,7 +146,22 @@ describe('install', () => {
         await install();
         const call = exec.exec.mock.calls[0];
         assert.equal(call.arguments[0], '"C:/tmp/box/setup.exe"');
-        assert.deepEqual(call.arguments[2], { windowsVerbatimArguments: true });
+        assert.deepEqual(call.arguments[2], { windowsVerbatimArguments: true, ignoreReturnCode: true });
+    });
+    it('warns and waits for the database if setup requests a reboot', async () => {
+        exec.exec.mock.mockImplementation(async () => 3010);
+        await install();
+        assert.equal(core.warning.mock.callCount(), 1);
+        assert.equal(core.warning.mock.calls[0].arguments[0], 'SQL Server setup succeeded but requested a reboot (exit code 3010); continuing without rebooting');
+        assert.equal(utils.waitForDatabase.mock.callCount(), 1);
+        assert.deepEqual(core.setOutput.mock.calls.map((c) => c.arguments), [['sa-password', 'secret password'], ['instance-name', 'MSSQLSERVER']]);
+    });
+    it('fails if setup exits with any other non-zero code', async () => {
+        exec.exec.mock.mockImplementation(async () => 1);
+        await assert.rejects(() => install(), { message: 'SQL Server setup failed with exit code 1' });
+        assert.equal(utils.waitForDatabase.mock.callCount(), 0);
+        assert.equal(core.setOutput.mock.callCount(), 0);
+        assert.equal(utils.gatherSummaryFiles.mock.calls[0].arguments[0], true);
     });
     it('runs an exe install', async () => {
         utils.gatherInputs.mock.mockImplementation(() => defaultInputs({ version: 'exe' }));