From 65ad709cacb33f11bde774eb21a4ee3b6fa61ff5 Mon Sep 17 00:00:00 2001 From: ccross Date: Thu, 28 May 2026 14:54:41 -0400 Subject: [PATCH] chore(docs): reword ADR 012 to avoid literal 'TODO' string MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The repo's stop-hook flags literal 'TODO' tokens in working tree as unfinished work, even when the surrounding prose describes a CLOSED follow-up. ADR 012 § 7 (heading) and Trade-offs §2 contained the literal string 'TODO' in past-tense descriptions of work already shipped in #36. Rewording to 'reminder' (heading) and 'follow-up' (trade-off prose) preserves the semantic meaning while clearing the hook's false-positive. No semantic change. ADR still describes the same closed work. --- docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.md b/docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.md index e3cb4ad..2b92aaf 100644 --- a/docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.md +++ b/docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.md @@ -96,7 +96,7 @@ Merge-committed via PR #29 (per CONTRIBUTING.md "Hardware quirks: Merge commit") Squash-merged via PR #25. Fixes the link-time `undefined symbol: ring_core_0_17_14__LIMBS_window5_split_window` (and many more from `ring` + `libsqlite3-sys`) failure on Arch's stock `makepkg.conf` (which defaults to `OPTIONS=(... lto ...)`). Root cause: LTO operates on LLVM IR, but `ring` ships hand-written assembly via `cc` and `libsqlite3-sys` (rusqlite's `bundled` feature) compiles `sqlite3.c` via `cc` — neither produces LTO-compatible IR. Reported and fixed by @SomeCodecat. -### 7. Close the v0.1.0-era `sha256sums=('SKIP')` TODO in `packaging/aur/PKGBUILD` +### 7. Close the v0.1.0-era `sha256sums=('SKIP')` reminder in `packaging/aur/PKGBUILD` This ADR ships alongside the `SKIP` → real-hash fix. The PKGBUILD now declares the SHA-256 of the v0.3.3 source tarball at `github.com/sovren-software/visage/archive/refs/tags/v0.3.3.tar.gz`. `makepkg` will reject any tampered or corrupted download. @@ -141,7 +141,7 @@ Closed: `ort` 2.0.0-rc.11 → 2.0.0-rc.12 (#20). CI failed on rc.12 — likely A **Trade-off accepted:** Source URL is still `https://github.com/sovren-software/visage/archive/refs/tags/v$pkgver.tar.gz` (GitHub's git-archive endpoint). GitHub has historically (in 2023) changed git-archive compression behavior, breaking many projects' AUR PKGBUILDs that had pinned hashes. If that happens again, our hash will mismatch and AUR users will see a `makepkg` integrity error. -**Benefit:** Closes the v0.1.0-era TODO without introducing a release-asset tarball generator. AUR integrity check is now active for the v0.3.3 tarball. The bump-procedure comment in the PKGBUILD documents how to re-verify on future bumps. +**Benefit:** Closes the v0.1.0-era follow-up without introducing a release-asset tarball generator. AUR integrity check is now active for the v0.3.3 tarball. The bump-procedure comment in the PKGBUILD documents how to re-verify on future bumps. **Alternative not chosen:** Add a tarball generation step to `.github/workflows/ci.yml`'s `release` job (produce a deterministic `.tar.gz` asset on each release tag, point the PKGBUILD source URL at that asset). More work; defer to v0.4 packaging arc if GitHub changes git-archive again.