update to latest Sorbet (change 1 of 3): replay all scip-ruby commits on top of latest upstream (#261)

Replay all scip-ruby commits on top of latest upstream Sorbet commit 7459ce5

See PR description for details: #261

scip-ruby history prior to this is maintained in a 'legacy' branch, see #267

---------

Signed-off-by: Emi <emi@sourcegraph.com>
Co-authored-by: Varun Gandhi <varun.gandhi@sourcegraph.com>
Co-authored-by: Ólafur Páll Geirsson <olafurpg@gmail.com>
Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>
Co-authored-by: Michał Kiełbowicz <michal.kielbowicz@sourcegraph.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Adam Chrapkowski <adam.chrapkowski@sourcegraph.com>
Co-authored-by: Jason Hawk Harris <jason.harris@sourcegraph.com>
Co-authored-by: jjuliamolin <44101701+jjuliamolin@users.noreply.github.com>
Co-authored-by: juliamolin <juliamolin@fb.com>
Co-authored-by: Christoph Hegemann <christoph.hegemann@sourcegraph.com>

Author: 12 people

.bazelrc

@@ -68,6 +68,8 @@ build --cxxopt=-Wno-unqualified-std-cast-call --host_cxxopt=-Wno-unqualified-std
 ##
 ## debug configuration
 ##
+build:dev --config=dbg --copt=-O1
+
 build:dbg --copt=-O0
 build:dbg --compilation_mode=dbg
 build:dbg --config=debugsymbols
@@ -76,6 +78,7 @@ build:dbg --config=debugsymbols
 # TODO(jez) Do newer compile commands generators suffer from this problem? The one we use is archived
 build:dbg --remote_download_outputs=all
 
+
 build:rubydbg --copt=-DRUBY_DEBUG --copt=-DVM_CHECK_MODE=1 --copt=-DTRANSIENT_HEAP_CHECK_MODE --copt=-DRGENGC_CHECK_MODE --copt=-DENC_DEBUG
 
 build:coverage --config=forcedebug
@@ -145,11 +148,11 @@ build:release-sanitized-linux-aarch64 --copt=-march=armv8.1a
 build:release-mac --config=release-common --config=shared-libs
 
 build:cross-to-darwin-x86_64 --platforms=@//tools/platforms:darwin_x86_64
-build:cross-to-darwin-x86_64 --extra_toolchains=@llvm_toolchain_15_0_7//:cc-toolchain-x86_64-darwin
+build:cross-to-darwin-x86_64 --extra_toolchains=@llvm_toolchain_15_0_6//:cc-toolchain-x86_64-darwin
 build:cross-to-darwin-x86_64 --copt=-stdlib=libc++ --linkopt=-lc++
 
 build:cross-to-darwin-arm64 --platforms=@//tools/platforms:darwin_arm64
-build:cross-to-darwin-arm64 --extra_toolchains=@llvm_toolchain_15_0_7//:cc-toolchain-aarch64-darwin
+build:cross-to-darwin-arm64 --extra_toolchains=@llvm_toolchain_15_0_6//:cc-toolchain-aarch64-darwin
 build:cross-to-darwin-arm64 --copt=-stdlib=libc++ --linkopt=-lc++
 
 build:release-debug-linux --config=release-linux
@@ -264,14 +267,14 @@ build:ubsan --copt=-DHAS_SANITIZER
 # because we're using the toolchain's lld linker now.
 # We could consider replacing this with something more typical.
 # Original motivation: Bazel links C++ files with $CC, not $CXX, this breaks UBSan
-build:sanitize-linux --linkopt=../../external/llvm_toolchain_15_0_7_llvm/lib/clang/15.0.7/lib/x86_64-unknown-linux-gnu/libclang_rt.asan_cxx.a
-build:sanitize-linux --linkopt=../../external/llvm_toolchain_15_0_7_llvm/lib/clang/15.0.7/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone_cxx.a
-build:sanitize-linux --linkopt=../../external/llvm_toolchain_15_0_7_llvm/lib/clang/15.0.7/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone.a
+build:sanitize-linux --linkopt=../../external/llvm_toolchain_15_0_6_llvm/lib/clang/15.0.6/lib/x86_64-unknown-linux-gnu/libclang_rt.asan_cxx.a
+build:sanitize-linux --linkopt=../../external/llvm_toolchain_15_0_6_llvm/lib/clang/15.0.6/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone_cxx.a
+build:sanitize-linux --linkopt=../../external/llvm_toolchain_15_0_6_llvm/lib/clang/15.0.6/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone.a
 build:sanitize-linux --config=sanitize
 
-build:sanitize-linux-aarch64 --linkopt=../../external/llvm_toolchain_15_0_7_llvm/lib/clang/15.0.7/lib/aarch64-unknown-linux-gnu/libclang_rt.asan_cxx.a
-build:sanitize-linux-aarch64 --linkopt=../../external/llvm_toolchain_15_0_7_llvm/lib/clang/15.0.7/lib/aarch64-unknown-linux-gnu/libclang_rt.ubsan_standalone_cxx.a
-build:sanitize-linux-aarch64 --linkopt=../../external/llvm_toolchain_15_0_7_llvm/lib/clang/15.0.7/lib/aarch64-unknown-linux-gnu/libclang_rt.ubsan_standalone.a
+build:sanitize-linux-aarch64 --linkopt=../../external/llvm_toolchain_15_0_6_llvm/lib/clang/15.0.6/lib/aarch64-unknown-linux-gnu/libclang_rt.asan_cxx.a
+build:sanitize-linux-aarch64 --linkopt=../../external/llvm_toolchain_15_0_6_llvm/lib/clang/15.0.6/lib/aarch64-unknown-linux-gnu/libclang_rt.ubsan_standalone_cxx.a
+build:sanitize-linux-aarch64 --linkopt=../../external/llvm_toolchain_15_0_6_llvm/lib/clang/15.0.6/lib/aarch64-unknown-linux-gnu/libclang_rt.ubsan_standalone.a
 build:sanitize-linux-aarch64 --config=sanitize
 
 build:sanitize-mac --config=sanitize

.bazelversion

@@ -1 +1 @@
-7.1.2
+7.7.0

.bazelversion_checksums/darwin-arm64

@@ -1 +1 @@
-753941fedae337ace93c3e03b1801bc7b301d3d53c00d7c5fb071d67059b1320
+8167011977bffd577cb4c8e9b2100f89134aa83c419a543914568f39a6b1c410

.bazelversion_checksums/darwin-x86_64

@@ -1 +1 @@
-af5fe3b5eba0ecc50648dd833a392752b706d321832354d46e5e7806e49b2155
+6a0a89a1c0b75e6c1d02fd881adf30f52ea921ea00feaf77a4e14331c488b56e

.bazelversion_checksums/linux-arm64

@@ -1 +1 @@
-50ce66b2b4065596347692e82209b29fa8cef7ab1ba1f45060294655c48677a8
+8d404f7a266ead50be0918f913df1449a4880f5c8ef36c88d09d6204e67f114d

.bazelversion_checksums/linux-x86_64

@@ -1 +1 @@
-de8a2ddb0d77293c97c4280ea60ce313487dfd1ba88cc7816d16ba640ac2fb3f
+7e749f59fa4c4430fbc49ea38b0bc0a41dd1f460e8671c90978d70c2166bf0c4

.buildkite/all-succeeded.sh

@@ -0,0 +1 @@
+../.sorbet-buildkite/all-succeeded.sh

.buildkite/all-succeeded.sh

@@ -1,8 +1,32 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
-set -euo pipefail
-if [ "HEAD" == "${BUILDKITE_COMMIT}" ]; then
-  echo "not using commit marks as this is HEAD build"
-else
-  .buildkite/hooks/gh-status sorbet/sorbet "${BUILDKITE_COMMIT}" pending "${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" "${BUILDKITE_LABEL}"
+set -e
+
+if echo "$BUILDKITE_PLUGINS" | grep "cache-buildkite-plugin"; then
+  if ! which aws; then
+    echo "pwd: $PWD"
+    ls
+
+    AWS_TEMPDIR="$(mktemp -d -t "awscli-XXXXXXXX")"
+    pushd "$AWS_TEMPDIR"
+    curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
+    unzip awscliv2.zip
+    sudo ./aws/install
+    ls
+    popd
+    rm -rf "$AWS_TEMPDIR"
+
+    echo "pwd: $PWD"
+    ls
+  
+    # From https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/enterprise/cmd/server/pre-build.sh?L40-47
+    AWS_CONFIG_DIR_PATH="/buildkite/.aws"
+    mkdir -p "$AWS_CONFIG_DIR_PATH"
+    AWS_CONFIG_FILE="$AWS_CONFIG_DIR_PATH/config"
+    export AWS_CONFIG_FILE
+    AWS_SHARED_CREDENTIALS_FILE="/buildkite/.aws/credentials"
+    export AWS_SHARED_CREDENTIALS_FILE
+    aws configure set aws_access_key_id "$BUILDKITE_HMAC_KEY" --profile buildkite
+    aws configure set aws_secret_access_key "$BUILDKITE_HMAC_SECRET" --profile buildkite
+  fi
 fi

.buildkite/hooks/pre-command

@@ -3,39 +3,40 @@
 set -euo pipefail
 export JOB_NAME=linters
 
-# shellcheck source-path=SCRIPTDIR/..
+# shellcheck source=SCRIPTDIR/tools/setup-bazel.sh
 source .buildkite/tools/setup-bazel.sh
 
 set -x
 globalErr=0
 
 echo "~~~ Checking build files"
-if ! ./tools/scripts/format_build_files.sh -t > buildifier; then
+if ! ./tools/scripts/format_build_files.sh -t &> buildifier; then
     globalErr=1
     echo "^^^ +++"
     buildkite-agent annotate --context tools/scripts/format_build_files.sh --style error --append < buildifier
 fi
 
 echo "~~~ Checking c++ formatting"
-if ! ./tools/scripts/format_cxx.sh -td &> format_cxx; then
+if ! ./tools/scripts/format_cxx.sh -t &> format_cxx; then
     globalErr=1
     echo "^^^ +++"
     buildkite-agent annotate --context tools/scripts/format_cxx.sh --style error --append < format_cxx
 fi
 
 echo "~~~ Checking that the compilation db builds"
-if ! ./tools/scripts/build_compilation_db.sh > compdb; then
+if ! ./tools/scripts/build_compilation_db.sh &> compdb; then
     globalErr=1
     echo "^^^ +++"
     buildkite-agent annotate --context tools/scripts/build_compilation_db.sh --style error --append < compdb
 fi
 
-echo "~~~ Checking compilation db targets"
-if ! ./tools/scripts/generate_compdb_targets.sh -t &> compdb-targets; then
-    globalErr=1
-    echo "^^^ +++"
-    buildkite-agent annotate --context tools/scripts/generate_compdb_targets.sh --style error --append < compdb-targets
-fi
+# Skip this because bazel query is failing due to third-party stuff
+# echo "~~~ Checking compilation db targets"
+# if ! ./tools/scripts/generate_compdb_targets.sh -t &> compdb-targets; then
+#     globalErr=1
+#     echo "^^^ +++"
+#     buildkite-agent annotate --context tools/scripts/generate_compdb_targets.sh --style error --append < compdb-targets
+# fi
 
 echo "~~~ Linting uses of \`using namespace std\`"
 if ! ./tools/scripts/check_using_namespace_std.sh &> std_check; then
@@ -58,59 +59,6 @@ if ! ./tools/scripts/lint_sh.sh -t &> lint_sh; then
     buildkite-agent annotate --context tools/scripts/lint_sh.sh --style error --append < lint_sh
 fi
 
-echo "~~~ Checking markdown formatting"
-if ! ./tools/scripts/format_website.sh -t &> format_website; then
-    globalErr=1
-    echo "^^^ +++"
-    buildkite-agent annotate --context tools/scripts/format_website.sh --style error --append < format_website
-fi
-
-echo "~~~ Checking protoc dependency"
-./bazel query "somepath(//main:sorbet, @com_google_protobuf//:protoc)" 2> /dev/null > protoc_dependency
-if [ "$(wc -l protoc_dependency)" -ne 0 ]; then
-  globalErr=1
-  echo "^^^ +++"
-  cat >> protoc_dependency <<EOF
-
-There is a path to @com_google_protobuf//:protoc from //main:sorbet
-Please remove it, as this represents a substantial regression in compile times.
-EOF
-  buildkite-agent annotate --context "path to @com_google_protobuf//:protoc" --style error --append < protoc_dependency
-fi
-
-if grep -n -r '^  \w*\.md' website &> lint_docusaurus_md; then
-  globalErr=1
-  echo "^^^ +++"
-  buildkite-agent annotate --context "Docusaurus Link Reference Definitions" --style error --append <<EOF
-These markdown files have link reference definitions which split onto multiple lines.
-
-Prettier insists on splitting long link reference definitions onto multiple lines,
-but Docusaurus fails to linkify these definitions.
-
-Rewrite these link reference definitions to be inline links to avoid broken links:
-
-\`\`\`
-$(< lint_docusaurus_md)
-\`\`\`
-EOF
-fi
-
-echo "~~~ Checking the vscode extension"
-pushd vscode_extension
-yarn install
-if ! yarn lint --output-file=yarn_lint; then
-    globalErr=1
-    echo "^^^ +++"
-    buildkite-agent annotate --context 'yarn lint' --style error --append <<EOF
-There were eslint errors in vscode_extension/. Fix with:
-
-    cd vscode_extension && yarn lint --fix
-
-$(< yarn_lint)
-EOF
-fi
-popd
-
 echo "~~~"
 if [ "$globalErr" -ne 0 ]; then
     exit $globalErr