From b2093a50487b993a91b4044d5f70127701ca8f2e Mon Sep 17 00:00:00 2001 From: M-arcus <25648755+M-arcus@users.noreply.github.com> Date: Tue, 8 Sep 2026 12:24:52 +0200 Subject: [PATCH 1/3] Fix listen Ip in test --- test/help/webserver.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/help/webserver.js b/test/help/webserver.js index 945e9d9..531f85d 100644 --- a/test/help/webserver.js +++ b/test/help/webserver.js @@ -80,7 +80,9 @@ export async function startServer(useHttp2) { if (!isListening) { await new Promise((resolveCb, rejectCb) => { server - .listen(0, '0.0.0.0') + // Loopback, not 0.0.0.0: the browsers run on this machine, and + // Firefox refuses http://0.0.0.0:port where Chrome tolerates it. + .listen(0, '127.0.0.1') .on('error', rejectCb) .on('listening', () => { isListening = true; From dfcd78304b3cfe2ed52f8e0912ab549c96451912 Mon Sep 17 00:00:00 2001 From: M-arcus <25648755+M-arcus@users.noreply.github.com> Date: Tue, 8 Sep 2026 12:26:28 +0200 Subject: [PATCH 2/3] Fix DOM bundle test asserting a non-AMP fixture is AMP --- test/api/domTest.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/api/domTest.js b/test/api/domTest.js index 26f161b..235a620 100644 --- a/test/api/domTest.js +++ b/test/api/domTest.js @@ -55,7 +55,11 @@ for (const browser of BROWSERS) { 30_000 ); const result = await driver.executeScript('return ' + bundle); - t.truthy(result?.advice?.info?.amp); + // Ordinary page, so info.amp is legitimately false — assert the + // bundle produced the info block, not that the page is AMP. + t.is(result.advice.info.amp, false); + t.truthy(result.advice.performance.adviceList); + t.is(result.url, url); } ); } From 70def5f056d56361c24ac175787c129e2eeebea6 Mon Sep 17 00:00:00 2001 From: M-arcus <25648755+M-arcus@users.noreply.github.com> Date: Tue, 8 Sep 2026 12:27:15 +0200 Subject: [PATCH 3/3] Add severity to the expected DOM advice keys --- test/dom/adviceTest.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/dom/adviceTest.js b/test/dom/adviceTest.js index 6357c47..aa5c227 100644 --- a/test/dom/adviceTest.js +++ b/test/dom/adviceTest.js @@ -11,6 +11,7 @@ const KEYS = [ 'advice', 'score', 'weight', + 'severity', 'offending', 'tags' ];