Repository navigation
Commit c715143
committed
ci: fix stable release publishing wrong npm versions
Stable releases published npm packages as "<old>-<new>" (e.g. 2.9.4-2.10.0)
and pointed the 'latest' dist-tag at them. Two causes:
- release.yml passed prerel_name for stable releases, so
npm:configure_prerelease appended the tag to the package version. That
suffix is only meaningful for nightlies.
- build.yml checked out the ref the workflow was dispatched on rather than
the tag, so it built the tree from *before* create-tag's version bump
commit. release-tag-ruby_wasm-gem already passed an explicit ref, which is
why the gems carried the right version while npm did not.
Add a 'ref' input to build.yml and thread it through every checkout, and
drop prerel_name from the stable path so the bumped version publishes as-is.
ci:publish took the tag from prerel_name, falling back to GITHUB_REF_NAME.
With prerel_name gone that fallback yields 'main' on a workflow_dispatch, so
add a separate 'release_tag' input for it.
Affected releases: 2.9.0, 2.9.4 and 2.10.0 published as 2.8.1-2.9.0,
2.9.3-2.9.4 and 2.9.4-2.10.0. The last clean stable npm version is 2.8.1.1 parent f1c909b commit c715143
2 files changed
Lines changed: 24 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
18 | 26 | | |
19 | 27 | | |
20 | 28 | | |
| |||
47 | 55 | | |
48 | 56 | | |
49 | 57 | | |
| 58 | + | |
| 59 | + | |
50 | 60 | | |
51 | 61 | | |
52 | 62 | | |
| |||
70 | 80 | | |
71 | 81 | | |
72 | 82 | | |
| 83 | + | |
| 84 | + | |
73 | 85 | | |
74 | 86 | | |
75 | 87 | | |
| |||
98 | 110 | | |
99 | 111 | | |
100 | 112 | | |
| 113 | + | |
101 | 114 | | |
102 | 115 | | |
103 | 116 | | |
| |||
164 | 177 | | |
165 | 178 | | |
166 | 179 | | |
| 180 | + | |
| 181 | + | |
167 | 182 | | |
168 | 183 | | |
169 | 184 | | |
| |||
179 | 194 | | |
180 | 195 | | |
181 | 196 | | |
182 | | - | |
183 | | - | |
| 197 | + | |
| 198 | + | |
184 | 199 | | |
185 | 200 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
81 | 86 | | |
82 | 87 | | |
83 | 88 | | |
| |||
0 commit comments