Skip to content

Inner shadows on Android need an upstream ShadowStyle design #23

Description

@rozd

Shadow tokens render on Android as drop shadows only; .inner is carried as data and ignored. View.androidThemeShadow(_:) in Sources/ThemeKit/Android/ is the current application point.

There is no upstream equivalent to lean on. Compose 1.11.4 (the BOM Skip pins) does have Modifier.dropShadow and Modifier.innerShadow, but a shadow attached to a brush — which is what .surface.cardShadow means — is not a Compose concept, so this is design work upstream rather than a mechanical port. The composeModifier escape hatch is the only other route.

Nothing is blocked on it: the drop-only behaviour is documented in README.md's support matrix and in docs/android-rendering.md. Filed so the gap is not lost.

Next step if picked up: open a design issue upstream describing the case, rather than a PR — let the maintainers steer the shape first.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions