[ci-review] Rector Rectify

Author: actions-user

scripts/src/NodeRuleMap/NodeRuleMapFactory.php

@@ -10,10 +10,10 @@
 use Rector\Scripts\Finder\RectorClassFinder;
 use ReflectionClass;
 
-final class NodeRuleMapFactory
+final readonly class NodeRuleMapFactory
 {
     public function __construct(
-        private readonly RectorClassFinder $rectorClassFinder
+        private RectorClassFinder $rectorClassFinder
     ) {
     }
 
@@ -54,7 +54,7 @@ public function create(array $ruleDirectories, array $nodeDirectories): array
      */
     private function resolveNodeTypesByRectorClass(array $ruleDirectories): array
     {
-        $ruleDirectories = array_filter($ruleDirectories, 'is_dir');
+        $ruleDirectories = array_filter($ruleDirectories, is_dir(...));
         $rectorClasses = $this->rectorClassFinder->find($ruleDirectories);
 
         $nodeTypesByRectorClass = [];
@@ -90,7 +90,7 @@ private function resolveNodeClasses(array $nodeDirectories): array
                 continue;
             }
 
-            if (! (new ReflectionClass($class))->isInstantiable()) {
+            if (! new ReflectionClass($class)->isInstantiable()) {
                 continue;
             }
 

scripts/validate-node-rule-map.php

@@ -38,15 +38,7 @@
 // keep only core rules from the committed map
 $committedCoreMap = [];
 foreach ($committedMap as $nodeClass => $ruleClasses) {
-    $coreRuleClasses = array_filter($ruleClasses, static function (string $ruleClass) use ($siblingNamespacePrefixes): bool {
-        foreach ($siblingNamespacePrefixes as $siblingNamespacePrefix) {
-            if (str_starts_with($ruleClass, $siblingNamespacePrefix)) {
-                return false;
-            }
-        }
-
-        return true;
-    });
+    $coreRuleClasses = array_filter($ruleClasses, static fn(string $ruleClass): bool => array_all($siblingNamespacePrefixes, fn(string $siblingNamespacePrefix): bool => !str_starts_with($ruleClass, $siblingNamespacePrefix)));
 
     $committedCoreMap[$nodeClass] = array_values($coreRuleClasses);
 }