Skip to content

Commit d394070

Browse files
committed
move remaining dead-code baseline into phpstan.neon, @api interface methods
1 parent 47100f4 commit d394070

4 files changed

Lines changed: 19 additions & 20 deletions

File tree

‎phpstan-baseline-dead-code.neon‎

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎phpstan.neon‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
includes:
22
- vendor/symplify/phpstan-rules/config/rector-rules.neon
3-
- phpstan-baseline-dead-code.neon
43

54
rules:
65
- Rector\Utils\PHPStan\Rule\RegisterRelatedPolyfillRectorRule
@@ -74,6 +73,12 @@ parameters:
7473
offloadCollectorData: false
7574

7675
ignoreErrors:
76+
# called magically by parent
77+
-
78+
message: '#^Unused Rector\\PhpParser\\Printer\\BetterStandardPrinter\:\:(pInterpolatedStringPart|pStmt_FileNode)$#'
79+
identifier: shipmonk.deadMethod
80+
path: src/PhpParser/Printer/BetterStandardPrinter.php
81+
7782
# the deprecated set objects are still resolved internally, until every extension bonds its rules
7883
-
7984
message: '#deprecated (class|interface) Rector\\(Set|Bridge)\\#'

‎rules/Php80/Contract/StrStartWithMatchAndRefactorInterface.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,13 @@
1515

1616
interface StrStartWithMatchAndRefactorInterface
1717
{
18+
/**
19+
* @api implemented by child classes
20+
*/
1821
public function match(Identical|NotIdentical|Equal|NotEqual $binaryOp): ?StrStartsWith;
1922

2023
/**
24+
* @api implemented by child classes
2125
* @return FuncCall|BooleanNot|null
2226
*/
2327
public function refactorStrStartsWith(StrStartsWith $strStartsWith): ?Node;

‎src/Set/Contract/SetInterface.php‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,18 @@
1414
*/
1515
interface SetInterface
1616
{
17+
/**
18+
* @api implemented by child classes
19+
*/
1720
public function getGroupName(): string;
1821

22+
/**
23+
* @api implemented by child classes
24+
*/
1925
public function getName(): string;
2026

27+
/**
28+
* @api implemented by child classes
29+
*/
2130
public function getSetFilePath(): string;
2231
}

0 commit comments

Comments
 (0)