[TypeDeclarationDocblocks] Widen empty nested array default to mixed[] in DocblockVarArrayFromPropertyDefaultsRector (#8474)

Author: TomasVotruba

rules-tests/TypeDeclarationDocblocks/Rector/Class_/DocblockVarArrayFromPropertyDefaultsRector/Fixture/skip_empty_nested_array.php.inc

@@ -6,7 +6,6 @@
 
 use PhpParser\Comment\Doc;
 use PhpParser\Node;
-use PhpParser\Node\ArrayItem;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\PropertyItem;
@@ -95,11 +94,6 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            // an empty nested array default generalizes to never[], which then rejects every real value assigned later
-            if ($this->hasEmptyNestedArray($soleProperty->default)) {
-                continue;
-            }
-
             $propertyDefaultType = $this->getType($soleProperty->default);
 
             $propertyPhpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($property);
@@ -129,29 +123,6 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
-    private function hasEmptyNestedArray(Array_ $array): bool
-    {
-        foreach ($array->items as $arrayItem) {
-            if (! $arrayItem instanceof ArrayItem) {
-                continue;
-            }
-
-            if (! $arrayItem->value instanceof Array_) {
-                continue;
-            }
-
-            if ($arrayItem->value->items === []) {
-                return true;
-            }
-
-            if ($this->hasEmptyNestedArray($arrayItem->value)) {
-                return true;
-            }
-        }
-
-        return false;
-    }
-
     private function hasUsefulParentPropertyVarTag(Class_ $class, Property $property, Type $propertyDefaultType): bool
     {
         $propertyName = $this->getName($property);