Skip to content

Commit bfee018

Browse files
authored
[dx] Deprecate CombineIfRector (#8413)
1 parent e6c36be commit bfee018

17 files changed

Lines changed: 15 additions & 460 deletions

‎config/set/if.php‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22

33
declare(strict_types=1);
44

5-
use Rector\CodeQuality\Rector\If_\CombineIfRector;
65
use Rector\Config\RectorConfig;
76

7+
// note: all if rules were moved to code quality and coding style sets, or deprecated
88
return static function (RectorConfig $rectorConfig): void {
9-
$rectorConfig->rules([
10-
CombineIfRector::class,
11-
]);
9+
$rectorConfig->rules([]);
1210
};

‎phpstan.neon‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@ parameters:
6565
constants: true
6666

6767
ignoreErrors:
68+
# keepComments() is a generic helper; do not narrow it after the deprecated CombineIfRector stopped calling it
69+
-
70+
identifier: typePerfect.narrowPublicClassMethodParamType
71+
path: src/BetterPhpDocParser/Comment/CommentsMerger.php
72+
6873
# the deprecated set objects are still resolved internally, until every extension bonds its rules
6974
-
7075
message: '#deprecated (class|interface) Rector\\(Set|Bridge)\\#'

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/CombineIfRectorTest.php‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/docblock.php.inc‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/fixture.php.inc‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/property_fetch_in_condition.php.inc‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/property_fetch_in_condition2.php.inc‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/skip_child_else.php.inc‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/skip_child_elseif.php.inc‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/CombineIfRector/Fixture/skip_more_statements.php.inc‎

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)