[perf] Speed up DeadCode rules by deferring docblock parse and parent reflection behind cheap guards (#8667)

Author: TomasVotruba

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingClassMethodRector.php

@@ -94,16 +94,16 @@ public function refactor(Node $node): ?int
             return null;
         }
 
-        if ($this->hasRefiningDocblock($node)) {
+        if (! $this->isParentCallDelegatingParams($node, $node->stmts[0])) {
             return null;
         }
 
-        $parentMethodReflection = $this->matchParentMethodReflection($node);
-        if (! $parentMethodReflection instanceof ExtendedMethodReflection) {
+        if ($this->hasRefiningDocblock($node)) {
             return null;
         }
 
-        if (! $this->isParentCallDelegatingParams($node, $node->stmts[0])) {
+        $parentMethodReflection = $this->matchParentMethodReflection($node);
+        if (! $parentMethodReflection instanceof ExtendedMethodReflection) {
             return null;
         }
 

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

@@ -108,24 +108,24 @@ public function refactor(Node $node): ?int
             return null;
         }
 
-        $parentMethodReflection = $this->matchParentConstructorReflection($node);
-        if (! $parentMethodReflection instanceof ExtendedMethodReflection) {
+        $soleStmt = $node->stmts[0];
+        $parentCallArgs = $this->matchParentConstructorCallArgs($soleStmt);
+        if ($parentCallArgs === null) {
             return null;
         }
 
-        // removing public constructor would expose the narrower parent one
-        if (! $parentMethodReflection->isPublic()) {
+        // match count and order
+        if (! $this->isParameterAndArgCountAndOrderIdentical($node)) {
             return null;
         }
 
-        $soleStmt = $node->stmts[0];
-        $parentCallArgs = $this->matchParentConstructorCallArgs($soleStmt);
-        if ($parentCallArgs === null) {
+        $parentMethodReflection = $this->matchParentConstructorReflection($node);
+        if (! $parentMethodReflection instanceof ExtendedMethodReflection) {
             return null;
         }
 
-        // match count and order
-        if (! $this->isParameterAndArgCountAndOrderIdentical($node)) {
+        // removing public constructor would expose the narrower parent one
+        if (! $parentMethodReflection->isPublic()) {
             return null;
         }
 

rules/DeadCode/Rector/ClassMethod/RemoveVoidDocblockFromMagicMethodRector.php

@@ -85,6 +85,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // early return if no @return tag is present
+        if (! str_contains((string) $node->getDocComment(), '@return')) {
+            return null;
+        }
+
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
 
         $returnTagValueNode = $phpDocInfo->getReturnTagValue();

rules/DeadCode/Rector/Foreach_/RemoveUnusedForeachKeyRector.php

@@ -100,6 +100,11 @@ public function refactor(Node $node): ?Node
             $stmt->keyVar = null;
             $hasChanged = true;
 
+            // no @var tag to clean up
+            if (! str_contains((string) $stmt->getDocComment(), '@var')) {
+                continue;
+            }
+
             $phpDocInfo = $this->phpDocInfoFactory->createFromNode($stmt);
             if (! $phpDocInfo instanceof PhpDocInfo) {
                 continue;