[Php86] Add ConstructorReadonlyAssignToDefaultRector for readonly property defaults (#8502)

Author: TomasVotruba

config/set/php-version-based.php

@@ -139,6 +139,7 @@
 use Rector\Php85\Rector\Property\AddOverrideAttributeToOverriddenPropertiesRector;
 use Rector\Php85\Rector\ShellExec\ShellExecFunctionCallOverBackticksRector;
 use Rector\Php85\Rector\Switch_\ColonAfterSwitchCaseRector;
+use Rector\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector;
 use Rector\Php86\Rector\FuncCall\MinMaxToClampRector;
 use Rector\Removing\Rector\FuncCall\RemoveFuncCallArgRector;
 use Rector\Removing\Rector\FuncCall\RemoveFuncCallRector;
@@ -325,6 +326,7 @@
 
         // PHP 8.6
         MinMaxToClampRector::class,
+        ConstructorReadonlyAssignToDefaultRector::class,
     ]);
 
     // configured rules, each bound to the PHP version its configuration targets

config/set/php86.php

@@ -3,8 +3,9 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector;
 use Rector\Php86\Rector\FuncCall\MinMaxToClampRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([MinMaxToClampRector::class]);
+    $rectorConfig->rules([MinMaxToClampRector::class, ConstructorReadonlyAssignToDefaultRector::class]);
 };

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/ConstructorReadonlyAssignToDefaultRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class ConstructorReadonlyAssignToDefaultRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/Fixture/class_const_default.php.inc

@@ -0,0 +1,34 @@
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class ClassConstDefault
+{
+    private const DEFAULT_NAME = 'value';
+
+    public readonly string $name;
+
+    public function __construct()
+    {
+        $this->name = self::DEFAULT_NAME;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class ClassConstDefault
+{
+    private const DEFAULT_NAME = 'value';
+
+    public readonly string $name = self::DEFAULT_NAME;
+
+    public function __construct()
+    {
+    }
+}
+
+?>

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/Fixture/fixture.php.inc

@@ -0,0 +1,30 @@
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class Fixture
+{
+    public readonly int $number;
+
+    public function __construct()
+    {
+        $this->number = 100;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class Fixture
+{
+    public readonly int $number = 100;
+
+    public function __construct()
+    {
+    }
+}
+
+?>

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/Fixture/skip_conditional_assign.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class SkipConditionalAssign
+{
+    public readonly int $number;
+
+    public function __construct(bool $flag)
+    {
+        if ($flag) {
+            $this->number = 100;
+        } else {
+            $this->number = 200;
+        }
+    }
+}

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/Fixture/skip_new_object.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class SkipNewObject
+{
+    public readonly \stdClass $value;
+
+    public function __construct()
+    {
+        $this->value = new \stdClass();
+    }
+}

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/Fixture/skip_not_readonly.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class SkipNotReadonly
+{
+    public int $number;
+
+    public function __construct()
+    {
+        $this->number = 100;
+    }
+}

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/Fixture/skip_variable_assign.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector\Fixture;
+
+final class SkipVariableAssign
+{
+    public readonly int $number;
+
+    public function __construct(int $number)
+    {
+        $this->number = $number;
+    }
+}

rules-tests/Php86/Rector/Class_/ConstructorReadonlyAssignToDefaultRector/config/configured_rule.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php86\Rector\Class_\ConstructorReadonlyAssignToDefaultRector;
+use Rector\ValueObject\PhpVersion;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(ConstructorReadonlyAssignToDefaultRector::class);
+
+    $rectorConfig->phpVersion(PhpVersion::PHP_86);
+};