Bump PHPStan to ^2.3.0 and fix compatible code (#8528)

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

build/target-repository/composer.json

@@ -9,7 +9,7 @@
     ],
     "require": {
         "php": "^7.4|^8.0",
-        "phpstan/phpstan": "^2.2.14"
+        "phpstan/phpstan": "^2.3.0"
     },
     "autoload": {
         "files": [

composer.json

@@ -24,7 +24,7 @@
         "nikic/php-parser": "^5.9",
         "ondram/ci-detector": "^4.2",
         "phpstan/phpdoc-parser": "^2.3.3",
-        "phpstan/phpstan": "^2.2.14",
+        "phpstan/phpstan": "^2.3.0",
         "react/child-process": "^0.6.5",
         "react/event-loop": "^1.6",
         "react/socket": "^1.17",

phpstan.neon

@@ -48,7 +48,6 @@ parameters:
 
     # see https://github.com/TomasVotruba/type-coverage
     type_coverage:
-        declare: 99
         return_type: 99
         param_type: 99
         property_type: 99

rules/DeadCode/Rector/ClassMethod/RemoveUselessAssignFromPropertyPromotionRector.php

@@ -121,11 +121,6 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        // empty data? nothing to remove
-        if ($removeStmtKeys === []) {
-            return null;
-        }
-
         foreach ($removeStmtKeys as $removeStmtKey) {
             unset($node->stmts[$removeStmtKey]);
         }

rules/EarlyReturn/Rector/If_/ChangeIfElseValueAssignToEarlyReturnRector.php

@@ -108,9 +108,9 @@ public function refactor(Node $node): ?Node
             /** @var Assign $assign */
             $assign = $this->stmtsManipulator->getUnwrappedLastStmt($if->stmts);
 
-            $returnLastIf = new Return_($assign->expr);
-            $this->mirrorComments($returnLastIf, $assign);
-            $if->stmts[$lastIfStmtKey] = $returnLastIf;
+            $return = new Return_($assign->expr);
+            $this->mirrorComments($return, $assign);
+            $if->stmts[$lastIfStmtKey] = $return;
 
             /** @var Else_ $else */
             $else = $if->else;

src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

@@ -731,6 +731,9 @@ private function processTrait(Trait_ $trait, MutatingScope $mutatingScope, calla
 
         $this->privatesAccessor->setPrivateProperty($traitScope, self::CONTEXT, $traitContext);
 
+        // the cloned scope keeps node callback scope cached from former context, reset it to use the trait context
+        $this->privatesAccessor->setPrivateProperty($traitScope, 'nodeCallbackScope', null);
+
         $trait->setAttribute(AttributeKey::SCOPE, $traitScope);
         $this->nodeScopeResolverProcessNodes($trait->stmts, $traitScope, $nodeCallback);
         $this->decorateNodeAttrGroups($trait, $traitScope, $nodeCallback);