Skip to content

_LOAD_ATTR_PROPERTY_FRAME has too weak checks that are also slow #148510

@Fidget-Spinner

Description

@Fidget-Spinner

Bug report

Bug description:

See title, apparently we used to check func_version, then we removed it in 5f60011

These checks are slower and too weak for the JIT. We should restore the func_version check. This should also improve the specializing interpreter, as a single func version check is faster than checking for a bunch of flags.

This comment in the JIT says the JIT is bugged for that uop as a result https://github.com/python/cpython/blob/main/Python/optimizer_bytecodes.c#L988

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-JITtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions