Repository navigation
Conversation
Adds timing instrumentation (performance.now()-based elapsed durations and byte counts) to the handshake socket client, the in-process handshake broker, and the Kallichore server-status probe used when reconnecting. This makes it possible to diagnose where time is spent during supervisor startup/reconnect without exposing any payload content, tokens, or other sensitive data in the logs. Fixes a latent type error where the cached handshake payload could be undefined when replayed back to a socket. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. |
mslynch
marked this pull request as draft
September 4, 2026 18:46
Removes the performance.now()-based elapsed-time computations and the wall-clock timestamp added in the previous commit. The log capture already timestamps each line, so recomputing elapsed durations here was redundant. Instead, log paired start/end boundary events with non-timing metadata: connection ID, report-in vs. cached-replay classification, byte counts, socket path, configured timeout, and success/failure (via the existing summarizeError helper). No payload content or tokens are logged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mslynch
changed the title
Keep the persistent boundary instrumentation self-explanatory rather than tying it to the current startup investigation.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mslynch
changed the title
Keep only the boundary events needed to distinguish handshake replay from status verification delays.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mslynch
changed the title
Member
|
@mslynch I notice this is still in draft. Are you waiting on us for this at all? Or should it stay here in this status still? |
Member
Author
|
No, I stopped working on the research this was intended to support. I'll just close it out for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds six boundary events around the two operations used to attach to a prestarted supervisor:
serverStatus()verification starts and completes or fails.The existing log timestamps can be compared to determine whether time was spent reaching the broker, replaying or receiving the cached handshake, reaching the status handler, or waiting for its response. No handshake payloads or bearer tokens are logged.
Testing
npx vitest run src/server-supervisor-handshake.vitest.tsnpm run build-check -- --pretty false