Skip to content

test_sigma_gen unit test fails #22

Description

@jimc101

The test is missing two arguments which specify the number of levels in the top and bottom boundary layers. The addition of these reflects a change to sigma_generalized function. In light of this, the reference values may be wrong.

More generally, I question whether this calculation is suitable for unit testing. It may be better tested in a notebook where different options for generating sigma grids are demonstrated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions