Formatting - PDSOE vs VsCode

[simondrum]

Hi @gquerret

Since I'm not sure if the formatter available in the latest "pre-release" is at its final version, maybe this post is completely irrelevant, maybe not

---

In the PDSOE code formatter options, the "DO:" on a new line is not an option, its on default.
To avoid diffs, is it possible to add it as an option?

In the same way, "ELSE IF" do not indent the same way. I like it better now but it create diffs and this will cause harder cherry-pick in the future

VsCode

PDSOE

[gquerret]

@simondrum We have exactly the same set of options as PDSOE, did you check you have the same settings? The aim of the formatter is to ensure compatibility with PDSOE so we don't plan to add any new options (Baltic Amadeus formatter has a wider set of options).
I also do not reproduce your ELSE IF behavior in PDSOE.

[simondrum]

Thanks,
Yes every option is checked the same. I also tries in PDSOE to check/uncheck and the "DO:" is always on a new line. Does it behave like this for you too? If not there might be a deeper configuration that I am not aware of

[gquerret]

The DO statement is never moved in my environment.

[stefandrissen]

Using PDSOE 13.0, if I choose context menu [ Source / Correct Indentation ] then it does move do: to the next line (yuck), [ Source / Format Source ] does not.

[gquerret]

We implemented the "format source" functionality, not the "correct indentation". I'll check internally about the details.

[simondrum]

Oh I never noticed the difference! thanks Stefan.
Thanks Gilles for watching, keep us posted please

[cptaps]

For me, any indented include (i.e. a line that has only whitespace before an opening curly parenthesis,) gets all leading whitespace removed, which appears to differ from PDSOE behavior. I also had to roll back latest release because it didn't seem to comply with "editor.formatOnSave" settings, so I couldn't turn the formatting off ... am I missing something?

[gquerret]

@cptaps Tried "Format source" with PDSOE on indented include references, they end up being indented at the same level as the previous statement in both VS Code and PDSOE.
The editor.formatOnSave works correctly in my environment. The language server receives the formatting request every time a file is saved.

[gquerret]

@cptaps Please create a new issue for these problems, that will be easier to track

[cptaps]

Thanks, and to clarify I have since found that formatOnSave "IS" working correctly. I will 'try' to reproduce the formatting issue(s) with code I can share and raise a new issue as requested. It's proving to be difficult to reproduce with simple code however so it might take some time.