Fix exclude targeted delivery field name

Author: esrakartalOpt

lib/optimizely/decision_service.rb

@@ -206,7 +206,7 @@ def get_decision_for_flag(feature_flag, user_context, project_config, decide_opt
 
         next unless holdout_decision.decision
 
-        if holdout['exclude_targeted_deliveries'] == true
+        if holdout['excludeTargetedDeliveries'] == true
           message = "Holdout \"#{holdout['key']}\" has excludeTargetedDeliveries enabled, continuing to rollout evaluation."
           @logger.log(Logger::INFO, message)
           reasons.push(message)

lib/optimizely/helpers/constants.rb

@@ -350,7 +350,7 @@ module Constants
                 'includedRules' => {
                   'type' => %w[array null]
                 },
-                'exclude_targeted_deliveries' => {
+                'excludeTargetedDeliveries' => {
                   'type' => 'boolean'
                 }
               }
@@ -373,7 +373,7 @@ module Constants
                 'includedRules' => {
                   'type' => %w[array null]
                 },
-                'exclude_targeted_deliveries' => {
+                'excludeTargetedDeliveries' => {
                   'type' => 'boolean'
                 }
               }

spec/decision_service_holdout_spec.rb

@@ -1035,7 +1035,7 @@
     end
   end
 
-  describe 'exclude_targeted_deliveries holdout behavior' do
+  describe 'excludeTargetedDeliveries holdout behavior' do
     let(:config_with_holdouts) do
       Optimizely::DatafileProjectConfig.new(
         OptimizelySpec::CONFIG_BODY_WITH_HOLDOUTS_JSON,
@@ -1058,10 +1058,10 @@
 
     after(:example) { project_with_holdouts&.close }
 
-    describe 'global holdout with exclude_targeted_deliveries' do
-      it 'applies holdout normally when exclude_targeted_deliveries is false' do
+    describe 'global holdout with excludeTargetedDeliveries' do
+      it 'applies holdout normally when excludeTargetedDeliveries is false' do
         global_holdout = config_with_holdouts.get_holdout('holdout_1')
-        global_holdout['exclude_targeted_deliveries'] = false
+        global_holdout['excludeTargetedDeliveries'] = false
 
         allow(ds).to receive(:get_variation_for_holdout)
           .with(global_holdout, anything, anything)
@@ -1125,10 +1125,10 @@
       end
     end
 
-    describe 'global holdout with missing exclude_targeted_deliveries (backward compat)' do
+    describe 'global holdout with missing excludeTargetedDeliveries (backward compat)' do
       it 'defaults to applying holdout normally when field is absent' do
         global_holdout = config_with_holdouts.get_holdout('holdout_1')
-        global_holdout.delete('exclude_targeted_deliveries')
+        global_holdout.delete('excludeTargetedDeliveries')
 
         allow(ds).to receive(:get_variation_for_holdout)
           .with(global_holdout, anything, anything)
@@ -1162,10 +1162,10 @@
       end
     end
 
-    describe 'local holdout with exclude_targeted_deliveries' do
-      it 'local holdout still applies even when exclude_targeted_deliveries is true' do
+    describe 'local holdout with excludeTargetedDeliveries' do
+      it 'local holdout still applies even when excludeTargetedDeliveries is true' do
         local_holdout = config_with_holdouts.get_holdout('holdout_local_1')
-        local_holdout['exclude_targeted_deliveries'] = true
+        local_holdout['excludeTargetedDeliveries'] = true
 
         experiment = config_with_holdouts.experiment_id_map['122227']
 
@@ -1203,15 +1203,15 @@
           user_profile_tracker
         )
 
-        # Local holdout MUST still apply — exclude_targeted_deliveries is ignored for local holdouts
+        # Local holdout MUST still apply — excludeTargetedDeliveries is ignored for local holdouts
         expect(result.holdout_decision).not_to be_nil
         expect(result.holdout_decision.source).to eq(Optimizely::DecisionService::DECISION_SOURCES['HOLDOUT'])
         expect(result.variation_id).to eq(local_holdout['variations'].first['id'])
       end
 
-      it 'applies local holdout for all rules even when exclude_targeted_deliveries is true' do
+      it 'applies local holdout for all rules even when excludeTargetedDeliveries is true' do
         local_holdout = config_with_holdouts.get_holdout('holdout_local_1')
-        local_holdout['exclude_targeted_deliveries'] = true
+        local_holdout['excludeTargetedDeliveries'] = true
 
         experiment = config_with_holdouts.experiment_id_map['122227']
 
@@ -1254,9 +1254,9 @@
         expect(result.holdout_decision.source).to eq(Optimizely::DecisionService::DECISION_SOURCES['HOLDOUT'])
       end
 
-      it 'applies local holdout normally when exclude_targeted_deliveries is false' do
+      it 'applies local holdout normally when excludeTargetedDeliveries is false' do
         local_holdout = config_with_holdouts.get_holdout('holdout_local_1')
-        local_holdout['exclude_targeted_deliveries'] = false
+        local_holdout['excludeTargetedDeliveries'] = false
 
         experiment = config_with_holdouts.experiment_id_map['122227']
 
@@ -1267,7 +1267,7 @@
             .and_return(Optimizely::DecisionService::DecisionResult.new(nil, false, []))
         end
 
-        # Local holdout fires even for TD rule because exclude_targeted_deliveries is false
+        # Local holdout fires even for TD rule because excludeTargetedDeliveries is false
         allow(ds).to receive(:get_variation_for_holdout)
           .with(local_holdout, anything, anything)
           .and_return(
@@ -1294,16 +1294,16 @@
           user_profile_tracker
         )
 
-        # Holdout applies to TD rule because exclude_targeted_deliveries is false
+        # Holdout applies to TD rule because excludeTargetedDeliveries is false
         expect(result.holdout_decision).not_to be_nil
         expect(result.holdout_decision.source).to eq(Optimizely::DecisionService::DECISION_SOURCES['HOLDOUT'])
       end
     end
 
-    describe 'global holdout exclude_targeted_deliveries integration with get_decision_for_flag' do
-      it 'skips experiments and returns rollout decision with holdout_decision attached when exclude_targeted_deliveries=true' do
+    describe 'global holdout excludeTargetedDeliveries integration with get_decision_for_flag' do
+      it 'skips experiments and returns rollout decision with holdout_decision attached when excludeTargetedDeliveries=true' do
         global_holdout = config_with_holdouts.get_holdout('holdout_1')
-        global_holdout['exclude_targeted_deliveries'] = true
+        global_holdout['excludeTargetedDeliveries'] = true
 
         holdout_variation = global_holdout['variations'].first
         holdout_dec = Optimizely::DecisionService::Decision.new(
@@ -1339,9 +1339,9 @@
         expect(result.holdout_decision.source).to eq(Optimizely::DecisionService::DECISION_SOURCES['HOLDOUT'])
       end
 
-      it 'returns nil decision with holdout_decision attached when exclude_targeted_deliveries=true and TD returns nil' do
+      it 'returns nil decision with holdout_decision attached when excludeTargetedDeliveries=true and TD returns nil' do
         global_holdout = config_with_holdouts.get_holdout('holdout_1')
-        global_holdout['exclude_targeted_deliveries'] = true
+        global_holdout['excludeTargetedDeliveries'] = true
 
         holdout_variation = global_holdout['variations'].first
         holdout_dec = Optimizely::DecisionService::Decision.new(
@@ -1384,10 +1384,10 @@
       end
     end
 
-    describe 'forced decision beats holdout with exclude_targeted_deliveries' do
-      it 'returns forced decision even when exclude_targeted_deliveries is true and holdout covers the rule' do
+    describe 'forced decision beats holdout with excludeTargetedDeliveries' do
+      it 'returns forced decision even when excludeTargetedDeliveries is true and holdout covers the rule' do
         local_holdout = config_with_holdouts.get_holdout('holdout_local_1')
-        local_holdout['exclude_targeted_deliveries'] = true
+        local_holdout['excludeTargetedDeliveries'] = true
         expect(local_holdout['trafficAllocation'].first['endOfRange']).to eq(10_000)
 
         experiment = config_with_holdouts.experiment_id_map['122227']