[FSSDK-12813] Remove ticket references from code comments per cross-sdk guideline

Author: jaeopt

lib/optimizely/event/event_factory.rb

@@ -109,10 +109,6 @@ def build_attribute_list(user_attributes, project_config)
       private
 
       def create_impression_event_visitor(impression_event)
-        # FSSDK-12813: Normalize campaign_id, variation_id, and entity_id
-        # uniformly across all decision types (experiment, feature test,
-        # rollout, holdout). No branching by decision type — every impression
-        # decision flows through this single normalization path.
         normalized_campaign_id = Helpers::EventIdValidator.normalize_campaign_id(
           impression_event.experiment_layer_id, impression_event.experiment_id
         )

lib/optimizely/helpers/event_id_validator.rb

@@ -18,7 +18,7 @@
 module Optimizely
   module Helpers
     # EventIdValidator normalizes ID fields on outgoing decision events so
-    # that the wire payload is byte-equivalent across SDKs (FSSDK-12813).
+    # that the wire payload is byte-equivalent across SDKs.
     #
     # Two contracts apply:
     #   * campaign_id and entity_id (impression events): valid iff non-empty

spec/event/event_factory_spec.rb

@@ -743,13 +743,13 @@
   end
 
   # ----------------------------------------------------------------------
-  # FSSDK-12813: Decision-event ID normalization tests.
+  # Decision-event ID normalization tests.
   #
   # These integration tests exercise the EventFactory wire payload to verify
   # that campaign_id, variation_id, and entity_id are normalized uniformly
   # across every decision type (experiment, feature test, rollout, holdout).
   # ----------------------------------------------------------------------
-  describe 'FSSDK-12813 decision event ID normalization' do
+  describe 'decision event ID normalization' do
     let(:event_context) do
       Optimizely::EventContext.new(
         region: 'US',
@@ -830,7 +830,7 @@ def first_event(log_event)
       expect(first_event(log_event)[:entity_id]).to eq('222222')
     end
 
-    it 'passes whitespace campaign_id through unchanged (FSSDK-12813 relaxed contract: non-empty string)' do
+    it 'passes whitespace campaign_id through unchanged (relaxed contract: non-empty string)' do
       # Per relaxed spec, any non-empty string is valid for campaign_id —
       # only empty string / nil / missing trigger the experiment_id fallback.
       impression = build_impression(
@@ -841,7 +841,7 @@ def first_event(log_event)
       expect(first_event(log_event)[:entity_id]).to eq('   ')
     end
 
-    it 'passes non-numeric opaque campaign_id through unchanged (FSSDK-12813 relaxed contract)' do
+    it 'passes non-numeric opaque campaign_id through unchanged (relaxed contract)' do
       # Per relaxed spec, opaque IDs such as "default-12345" or "layer_abc"
       # are valid for campaign_id and entity_id; only empty/null trigger the
       # experiment_id fallback.
@@ -853,7 +853,7 @@ def first_event(log_event)
       expect(first_event(log_event)[:entity_id]).to eq('campaign_a')
     end
 
-    it 'passes prefixed opaque campaign_id (default-12345) through unchanged (FSSDK-12813)' do
+    it 'passes prefixed opaque campaign_id (default-12345) through unchanged' do
       impression = build_impression(
         experiment_layer_id: 'default-12345', experiment_id: '222222', variation_id: '333333'
       )

spec/helpers/event_id_validator_spec.rb

@@ -124,7 +124,7 @@
       expect(described_class.normalize_campaign_id('111122', '999888')).to eq('111122')
     end
 
-    it 'returns the campaign_id unchanged when it is a non-empty opaque string (FSSDK-12813 relaxed contract)' do
+    it 'returns the campaign_id unchanged when it is a non-empty opaque string (relaxed contract)' do
       # FR-001: any non-empty string is valid for campaign_id; opaque IDs
       # like "default-12345" or "layer_abc" pass through unchanged.
       expect(described_class.normalize_campaign_id('default-12345', '999888')).to eq('default-12345')
@@ -133,9 +133,9 @@
     end
 
     it 'returns the campaign_id unchanged when it is a whitespace-only string (non-empty per spec)' do
-      # FSSDK-12813: whitespace is non-empty, so it passes through. The
-      # upstream datafile producer is responsible for content quality;
-      # SDK only enforces non-emptiness.
+      # Whitespace is non-empty, so it passes through. The upstream datafile
+      # producer is responsible for content quality; SDK only enforces
+      # non-emptiness.
       expect(described_class.normalize_campaign_id('   ', '999888')).to eq('   ')
     end
 
@@ -147,7 +147,7 @@
       expect(described_class.normalize_campaign_id('', '999888')).to eq('999888')
     end
 
-    it 'returns experiment_id (opaque string) when campaign_id is empty (FSSDK-12813 relaxed contract)' do
+    it 'returns experiment_id (opaque string) when campaign_id is empty (relaxed contract)' do
       # FR-002 fallback also accepts opaque experiment_id values.
       expect(described_class.normalize_campaign_id('', 'exp_42')).to eq('exp_42')
     end
@@ -190,8 +190,8 @@
     end
 
     it 'returns nil when variation_id is a non-numeric placeholder string' do
-      # FSSDK-12813: variation_id stays strict (FR-003/FR-004) — opaque
-      # placeholders like "variation_a" normalize to nil unlike campaign_id.
+      # variation_id stays strict (FR-003/FR-004) — opaque placeholders like
+      # "variation_a" normalize to nil unlike campaign_id.
       expect(described_class.normalize_variation_id('variation_a')).to be_nil
     end
 

spec/project_spec.rb

@@ -4052,9 +4052,6 @@ def callback(_args); end
               decisions: [{
                 campaign_id: '',
                 experiment_id: '',
-                # FSSDK-12813: empty/whitespace/non-numeric variation_id
-                # normalizes to nil per spec (variation_id retains the
-                # strict numeric-string-only contract).
                 variation_id: nil,
                 metadata: {
                   flag_key: 'multi_variate_feature',