Skip to content

Commit 12cf189

Browse files
committed
[FSSDK-12670] Address review feedback: fix log message
1 parent b987ccc commit 12cf189

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎lib/optimizely/odp/odp_manager.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def identify_user(identifiers:)
104104

105105
valid_identifiers = identifiers.select { |_k, v| v && !v.to_s.empty? }
106106
if valid_identifiers.length < 2
107-
@logger.log(Logger::DEBUG, 'ODP identify event is not dispatched (only one identifier provided).')
107+
@logger.log(Logger::DEBUG, 'ODP identify event is not dispatched (fewer than 2 valid identifiers).')
108108
return
109109
end
110110

‎spec/odp/odp_manager_spec.rb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,8 @@
239239
manager.stop!
240240
end
241241

242-
it 'should not send event when only one identifier provided' do
243-
expect(spy_logger).to receive(:log).with(Logger::DEBUG, 'ODP identify event is not dispatched (only one identifier provided).')
242+
it 'should not send event when fewer than 2 valid identifiers' do
243+
expect(spy_logger).to receive(:log).with(Logger::DEBUG, 'ODP identify event is not dispatched (fewer than 2 valid identifiers).')
244244

245245
manager = Optimizely::OdpManager.new(disable: false, logger: spy_logger)
246246
manager.update_odp_config(api_key, api_host, segments_to_check)
@@ -250,7 +250,7 @@
250250
end
251251

252252
it 'should not count empty or nil identifier values' do
253-
expect(spy_logger).to receive(:log).with(Logger::DEBUG, 'ODP identify event is not dispatched (only one identifier provided).')
253+
expect(spy_logger).to receive(:log).with(Logger::DEBUG, 'ODP identify event is not dispatched (fewer than 2 valid identifiers).')
254254

255255
manager = Optimizely::OdpManager.new(disable: false, logger: spy_logger)
256256
manager.update_odp_config(api_key, api_host, segments_to_check)

0 commit comments

Comments
 (0)