Skip to content

sysutils/git-backup: not backing up new firewall rules #5440

@zoechi

Description

@zoechi

Important notices

Describe the bug

I just migrated legacy firewall rules to the new rules.
Git backup didn't produce a commit.
Clicking "Setup/Test Git" produced a new commit, but didn't include new rules and didn't remove legacy rules.

The commit diff only contains

<backup><git persisted_at="<new timestamp>">

<revision>
  <description>/diag_backup.php made changes</description>
  <time><changed timestamp></time>

To Reproduce

Steps to reproduce the behavior:

  1. migrate legacy firewall rules
  2. click "Setup/Test Git" in System > Configuration > Backups
  3. check backup

Expected behavior

Configuration changes should invoke Git backup and Git backup should include the changes

Additional context

This issue could be related to #10289

Git backup worked flawlessy before. The last backup commit was 17h ago.
I updated OPNSense to 26.1.8. Before it was the latest version available yesterday.

When I diff backup files created with "Download configuration" from before and after the rules migration, lots of removal and addition of rules are shown.

Environment

OPNsense 26.1.8 (amd64).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions