From e0977f41218cd9cdb9178aa2f8c916660ff95175 Mon Sep 17 00:00:00 2001 From: n-dusan Date: Thu, 17 Sep 2026 15:17:32 +0200 Subject: [PATCH] fix(cd): install libxml2 through vcpkg for the Windows release build The libxml build script finds libxml2 through vcpkg on MSVC, but the windows-latest runner has no libxml2 installed, so every release since v0.6.8 failed to upload a Windows binary. Install the x64-windows-static-md triplet (the vcpkg crate's default) and point VCPKG_ROOT at the runner's vcpkg. --- .github/workflows/cd.yml | 8 ++++++++ CHANGELOG.md | 4 ++++ 2 files changed, 12 insertions(+) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 0cfcce2c..9df5a5f7 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -38,6 +38,14 @@ jobs: runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 + # `libxml` finds libxml2 through vcpkg on MSVC. Install the static + # (dynamic CRT) triplet so the released binary does not need libxml2 DLLs. + - name: Install libxml2 (Windows) + if: runner.os == 'Windows' + shell: pwsh + run: | + vcpkg install libxml2:x64-windows-static-md + "VCPKG_ROOT=$env:VCPKG_INSTALLATION_ROOT" >> $env:GITHUB_ENV - uses: taiki-e/upload-rust-binary-action@4398438f25ce68e99e82e90744c88604b9b218a3 with: # (required) Comma-separated list of binary names (non-extension portion of filename) to build and upload. diff --git a/CHANGELOG.md b/CHANGELOG.md index ffb995e1..4700f561 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,8 +14,12 @@ and this project adheres to a _modified_ form of _[Semantic Versioning][semver]_ ### Fixed +- Build the Windows release binary by installing libxml2 through vcpkg in CI ([#130]) + ### Removed +[#130]: https://github.com/openlawlibrary/taf-server/pull/130 + ## [v0.7.0-alpha.1] ### Added