From 164654b5e3185ca15c251103488017136333cffb Mon Sep 17 00:00:00 2001
From: Thiago Festa <tfesta@linkedin.com>
Date: Wed, 14 Jun 2023 14:20:23 -0700
Subject: [PATCH] added tracked to isLoading and isError; added tests

---
 .../models-table-server-paginated.ts          |  2 +
 .../models-table-server-paginated-test.js     | 67 ++++++++++++++++++-
 2 files changed, 68 insertions(+), 1 deletion(-)

diff --git a/addon/components/models-table-server-paginated.ts b/addon/components/models-table-server-paginated.ts
index be524a66..f03212aa 100644
--- a/addon/components/models-table-server-paginated.ts
+++ b/addon/components/models-table-server-paginated.ts
@@ -164,12 +164,14 @@ export default class ModelsTableServerPaginated extends ModelsTable<ModelsTableS
    * True if data is currently being loaded from the server.
    * Can be used in the template to e.g. display a loading spinner.
    */
+  @tracked
   isLoading = false;
 
   /**
    * True if last data query promise has been rejected.
    * Can be used in the template to e.g. indicate stale data or to e.g. show error state.
    */
+  @tracked
   isError = false;
 
   /**
diff --git a/tests/integration/components/models-table-server-paginated-test.js b/tests/integration/components/models-table-server-paginated-test.js
index 6bab5823..60f2d748 100644
--- a/tests/integration/components/models-table-server-paginated-test.js
+++ b/tests/integration/components/models-table-server-paginated-test.js
@@ -1,6 +1,6 @@
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
-import { waitUntil, render, settled } from '@ember/test-helpers';
+import { waitUntil, render, settled, find } from '@ember/test-helpers';
 import hbs from 'htmlbars-inline-precompile';
 import { setupMirage } from 'ember-cli-mirage/test-support';
 import { generateColumns, generateContent } from '../../helpers/f';
@@ -522,4 +522,69 @@ module('ModelsTableServerPaginated | Integration', function (hooks) {
     await a11yAudit('.models-table-wrapper');
     assert.ok(true, 'no a11y errors found');
   });
+
+  test('isLoading is yielded and updates according to the promise status', async function (assert) {
+    await render(
+      hbs`<ModelsTableServerPaginated
+        @themeInstance={{this.themeInstance}}
+        @data={{this.data}}
+        @columns={{this.columns}}
+        @filterQueryParameters={{this.filterQueryParameters}}
+        @itemsCount={{this.itemsCount}}
+        @pagesCount={{this.pagesCount}}
+        @doQuery={{this.doQuery}} as |MT|>
+        {{#if MT.isLoading}}
+          <div data-test-is-loading>loading...</div>
+        {{else}}
+          <MT.Table />
+          <MT.Footer />
+        {{/if}}
+      </ModelsTableServerPaginated>`
+    );
+    navigation.goToNextPage();
+    await waitUntil(() => find('[data-test-is-loading]'));
+    assert.ok(
+      find('[data-test-is-loading]'),
+      'Loading state should be present'
+    );
+    await settled();
+    assert.ok(
+      /Show 11 - 20 of 100( clear)? Clear all filters/.test(
+        this.ModelsTablePageObject.summary
+      ),
+      `Content for 2nd page (10) "${this.ModelsTablePageObject.summary}"`
+    );
+  });
+
+  test('isError is yielded and updates according to the promise status', async function (assert) {
+    await render(
+      hbs`<ModelsTableServerPaginated
+        @themeInstance={{this.themeInstance}}
+        @data={{this.data}}
+        @columns={{this.columns}}
+        @filterQueryParameters={{this.filterQueryParameters}}
+        @itemsCount={{this.itemsCount}}
+        @pagesCount={{this.pagesCount}}
+        @doQuery={{this.doQuery}} as |MT|>
+        {{#if MT.isError}}
+          <div data-test-is-error>error!</div>
+        {{else}}
+          <MT.Table />
+          <MT.Footer />
+        {{/if}}
+      </ModelsTableServerPaginated>`
+    );
+
+    this.server.get(
+      '/users',
+      () => ({
+        errors: ['Unknown error!'],
+      }),
+      500
+    );
+
+    await navigation.goToNextPage();
+    await settled();
+    assert.ok(find('[data-test-is-error]'), 'Error state should be present');
+  });
 });