Skip to content

ClairS - #8213

Open
robert-a-forsyth wants to merge 9 commits into
nf-core:masterfrom
robert-a-forsyth:ClairS
Open

ClairS#8213
robert-a-forsyth wants to merge 9 commits into
nf-core:masterfrom
robert-a-forsyth:ClairS

Conversation

@robert-a-forsyth

@robert-a-forsyth robert-a-forsyth commented Apr 4, 2025 •

Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Adds ClairS, small somatic variant caller for tumor-normal paired samples. Unfortunately Conda isn't available for this, but it does have support on singularity and docker

@SPPearce SPPearce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for the tool to be added to bioconda?
That would also make biocontainers docker and singularity images automatically.
We don't really like having custom docker images.

@famosab

famosab commented Apr 8, 2026

Copy link
Copy Markdown
Member

@robert-a-forsyth any news on this? do you have time to tackle it? :)

@SPPearce

Copy link
Copy Markdown
Contributor

@robert-a-forsyth , do you have time to finish this off?

@DylanMHouse

Copy link
Copy Markdown
Contributor

Hi, is there any updates on this module?

@DylanMHouse

Copy link
Copy Markdown
Contributor

I will ask the developers of ClairS if it would be possible to add the bioconda package, and maybe we could finalise this module? I am actually needing this so it would be great to have it on nf-core

@SPPearce

Copy link
Copy Markdown
Contributor

@DylanMHouse , feel free to take over the implementation.
You can make your own bioconda recipe (relatively straightforward these days with LLMs)

@DylanMHouse

Copy link
Copy Markdown
Contributor

@SPPearce I 'll continue development of this module then. I will wait a bit until the developers respond to my issue for a few days. Otherwise, I'll make that biocoda recipe and adapt the module to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants