Skip to content

Update sawfish/jointcall container to version 2.3.1 - #13490

Open
alkc wants to merge 6 commits into
masterfrom
alkc/update-sawfish-joint-call
Open

alkc wants to merge 6 commits into
masterfrom
alkc/update-sawfish-joint-call

Conversation

@alkc

@alkc alkc commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

PR checklist

Closes #13437

Updates SAWFISH/JOINTCALL to version 2.3.1

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mashehu

mashehu commented Oct 29, 2026

Copy link
Copy Markdown
Member

you need to update the environment.yml as well (and then nf-core modules bump-version does almost all the rest (except for snapshot updates)

@github-actions github-actions Bot added size/s and removed size/xs labels Oct 29, 2026
@alkc

alkc commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

[...] (and then nf-core modules bump-version does almost all the rest (except for snapshot updates)

Thanks for the tip. I'll try it when I update sawfish/discover next

@alkc
alkc marked this pull request as ready for review October 29, 2026 12:58
@alkc
alkc requested review from fellen31 and padraicc October 29, 2026 13:56
@alkc alkc mentioned this pull request Oct 29, 2026
4 of 18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update module: SAWFISH/JOINTCALL

2 participants