Skip to content

Commit fc58da3

Browse files
committed
will it blend?
1 parent d9a6c9f commit fc58da3

5 files changed

Lines changed: 11 additions & 42 deletions

File tree

‎src/main/java/com/mindee/v2/MindeeClient.java‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import com.mindee.v2.parsing.search.BaseSearchResponse;
1515
import com.mindee.v2.parsing.search.SearchResponse;
1616
import com.mindee.v2.product.extraction.ExtractionResponse;
17+
import com.mindee.v2.search.models.ModelSearchParameters;
1718
import java.io.IOException;
1819
import java.util.concurrent.CancellationException;
1920

@@ -213,7 +214,7 @@ public <TSearchResponse extends BaseSearchResponse> TSearchResponse search(
213214
*/
214215
@Deprecated
215216
public SearchResponse searchModels() {
216-
return searchModels(null, null);
217+
return search(SearchResponse.class, null);
217218
}
218219

219220
/**
@@ -225,7 +226,7 @@ public SearchResponse searchModels() {
225226
*/
226227
@Deprecated
227228
public SearchResponse searchModels(String modelName) {
228-
return searchModels(modelName, null);
229+
return search(SearchResponse.class, ModelSearchParameters.builder().name(modelName).build());
229230
}
230231

231232
/**
@@ -238,7 +239,10 @@ public SearchResponse searchModels(String modelName) {
238239
*/
239240
@Deprecated
240241
public SearchResponse searchModels(String modelName, String modelType) {
241-
return mindeeApi.reqGetSearchModels(modelName, modelType);
242+
return search(
243+
SearchResponse.class,
244+
ModelSearchParameters.builder().name(modelName).modelType(modelType).build()
245+
);
242246
}
243247

244248
/**

‎src/main/java/com/mindee/v2/http/MindeeApiV2.java‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.mindee.v2.parsing.JobResponse;
1111
import com.mindee.v2.parsing.error.ErrorResponse;
1212
import com.mindee.v2.parsing.search.BaseSearchResponse;
13-
import com.mindee.v2.parsing.search.SearchResponse;
1413
import com.mindee.v2.product.ProductAttributes;
1514
import java.io.IOException;
1615

@@ -74,15 +73,6 @@ public abstract <TSearchResponse extends BaseSearchResponse> TSearchResponse req
7473
BaseSearchParameters parameters
7574
);
7675

77-
/**
78-
* Retrieves a list of models.
79-
*
80-
* @param modelName search term for model name
81-
* @param modelType search term for model type
82-
*/
83-
@Deprecated
84-
public abstract SearchResponse reqGetSearchModels(String modelName, String modelType);
85-
8676
/**
8777
* Creates an "unknown error" response from an HTTP status code.
8878
*/
@@ -102,7 +92,7 @@ protected ProductAttributes getResponseProductInfo(
10292
var productInfo = responseClass.getAnnotation(ProductAttributes.class);
10393
if (productInfo == null) {
10494
throw new MindeeException(
105-
"The class " + responseClass.getSimpleName() + " is not annotated with @ProductInfo"
95+
"The class " + responseClass.getSimpleName() + " is not annotated with @ProductAttributes"
10696
);
10797
}
10898
return productInfo;
@@ -114,7 +104,7 @@ protected ProductAttributes getParamsProductAttributes(
114104
var productInfo = responseClass.getAnnotation(ProductAttributes.class);
115105
if (productInfo == null) {
116106
throw new MindeeException(
117-
"The class " + responseClass.getSimpleName() + " is not annotated with @ProductInfo"
107+
"The class " + responseClass.getSimpleName() + " is not annotated with @ProductAttributes"
118108
);
119109
}
120110
return productInfo;

‎src/main/java/com/mindee/v2/http/MindeeHttpApiV2.java‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import com.mindee.v2.parsing.JobResponse;
1313
import com.mindee.v2.parsing.error.ErrorResponse;
1414
import com.mindee.v2.parsing.search.BaseSearchResponse;
15-
import com.mindee.v2.parsing.search.SearchResponse;
1615
import java.io.IOException;
1716
import java.net.URISyntaxException;
1817
import java.nio.charset.StandardCharsets;
@@ -173,25 +172,6 @@ public <TSearchResponse extends BaseSearchResponse> TSearchResponse reqGetSearch
173172
return this.executeAPIRequest(get, responseClass);
174173
}
175174

176-
@Override
177-
@Deprecated
178-
public SearchResponse reqGetSearchModels(String modelName, String modelType) {
179-
URIBuilder url;
180-
try {
181-
url = new URIBuilder(this.mindeeSettings.getBaseUrl() + "/search/models");
182-
} catch (URISyntaxException e) {
183-
throw new RuntimeException(e);
184-
}
185-
if (modelName != null) {
186-
url.addParameter("name", modelName);
187-
}
188-
if (modelType != null) {
189-
url.addParameter("model_type", modelType);
190-
}
191-
var get = new HttpGet(url.toString());
192-
return executeAPIRequest(get, SearchResponse.class);
193-
}
194-
195175
/**
196176
* Ensures that a caller-supplied inference URL targets the configured Mindee
197177
* base URL so the {@code Authorization} header attached by

‎src/main/java/com/mindee/v2/parsing/search/SearchResponse.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.mindee.v2.parsing.search;
22

33
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
4+
import com.mindee.v2.product.ProductAttributes;
45
import com.mindee.v2.search.models.ModelSearchResponse;
56
import lombok.AllArgsConstructor;
67
import lombok.EqualsAndHashCode;
@@ -14,6 +15,7 @@
1415
@JsonIgnoreProperties(ignoreUnknown = true)
1516
@AllArgsConstructor
1617
@Deprecated
18+
@ProductAttributes(slug = "models")
1719
public class SearchResponse extends ModelSearchResponse {
1820

1921
}

‎src/test/java/com/mindee/v2/MindeeClientTest.java‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import com.mindee.v2.parsing.CommonResponse;
1818
import com.mindee.v2.parsing.JobResponse;
1919
import com.mindee.v2.parsing.search.BaseSearchResponse;
20-
import com.mindee.v2.parsing.search.SearchResponse;
2120
import com.mindee.v2.product.extraction.ExtractionResponse;
2221
import com.mindee.v2.product.extraction.params.ExtractionParameters;
2322
import com.mindee.v2.search.models.ModelSearchResponse;
@@ -69,12 +68,6 @@ public <TSearchResponse extends BaseSearchResponse> TSearchResponse reqGetSearch
6968
return (TSearchResponse) new ModelSearchResponse();
7069
}
7170

72-
@Override
73-
@Deprecated
74-
public SearchResponse reqGetSearchModels(String modelName, String modelType) {
75-
return new SearchResponse();
76-
}
77-
7871
@Override
7972
public <TResponse extends CommonResponse> TResponse reqGetResultById(
8073
Class<TResponse> tResponseClass,

0 commit comments

Comments
 (0)