Skip to content

Async methods do not support cancellation #588

@michaelelleby

Description

@michaelelleby

https://github.com/microsoft/FeatureManagement-Dotnet/blob/main/src/Microsoft.FeatureManagement/IFeatureManager.cs does not support https://learn.microsoft.com/en-us/dotnet/csharp/asynchronous-programming/cancel-an-async-task-or-a-list-of-tasks as is best practices in asynchronous programming.

Furthermore the overload Task<bool> IsEnabledAsync<TContext>(string feature, TContext context); gladly accepts CancellationToken as the context parameter, further adding confusion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions