abi: ABI functions don't respect function selector prefixes

[mhw0]

the function test(address[])
and addresses passed to the function is parameter is [0x10ed43c718714eb63d5aa57b78b54704e256024e,0x13f4ea83d0bd40e75c8222255bc855a974568dd4]

the encoded form
0xd57498ea0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000200000000000000000000000010ed43c718714eb63d5aa57b78b54704e256024e00000000000000000000000013f4ea83d0bd40e75c8222255bc855a974568dd4

i use the following code to decode the ABI function inputs

struct eth_abi abi = {};
char *fn = strdup(func.c_str()), *hex;
eth_abi_from_hex(&abi, input, data.length());
eth_abi_call(&abi, &fn, NULL)
eth_abi_array(&abi, &arrlen); // array beign
                    std::cout<<"array length: "<<arrlen<<" \n";
                    char *val[arrlen];
                    for (int j = 0; j < arrlen; j++)
                    {
                        eth_abi_address(&abi, &val[j]);
                        string a(val[j]);
                        result.push_back("0x" + a);
                    }
                    eth_abi_array_end(&abi); // array end
                    arrlen = 0;
eth_abi_call_end(&abi)

output is

array length: 0

Originally posted by @DerXanRam in #66

[mhw0]

624d75f should fix the issue. Can you try please?

I noticed that you're not allocating memory for eth_abi_address, please don't forget to allocate memory first and then decode.

[DerXanRam]

i tested for bool,address,uint8,uint16,uint32,uint64,mpint arrays and it is working on encoding and decoding. however to encode arbitrary negative numbers using eth_abi_mpint , i have to add this line of code and it works 🟢 .

mp_int val;
                            mp_init(&val);

                            std::string s = temp;
                            std::cout << "num to encode is: " << temp << std::endl;
                            bool is_negative = false;

                            // Handle optional sign
                            if (!s.empty() && s[0] == '-')
                            {
                                is_negative = true;
                                s = s.substr(1); // Remove the negative sign for now
                            }

                            // Convert the sanitized string
                            mp_read_radix(&val, s.c_str(), 10);

                            if (is_negative)
                            {
                                mp_neg(&val, &val);
                            }

                            eth_abi_mpint(&abi, &val);

and i am still trying to encode bytes and bytes[]. bytes[] decoding is working. but encoding of bytes[] is not working even on older version i am actively using for production.

[DerXanRam]

I noticed that you're not allocating memory for eth_abi_address, please don't forget to allocate memory first and then decode.

i don't understand what you said bro...

[mhw0]

i have to add this line of code and it works

if the input has -, mp_read_radix reads that integer as negative and I don't think you have to manually call mp_neg.

I noticed that you're not allocating memory for eth_abi_address, please don't forget to allocate memory first and then decode.

i don't understand what you said bro...

nevermind, totally forgot that eth_abi_address allocates memory for you. But, it shouldn't and we should try to avoid allocating heap memory as much as possible.

and i am still trying to encode bytes and bytes[]. bytes[] decoding is working. but encoding of bytes[] is not working even on older version i am actively using for production.

Can you please send the data you're trying to encode? I'll test myself

[DerXanRam]

Can you please send the data you're trying to encode? I'll test myself
please check #59 . i reopened the issue

[DerXanRam]

any new update bro?

[mhw0]

any new update bro?

Hi, saw the issue. Fixing it