Skip to content

fix: use QImage::flipped() for Qt6 compatibility - #409

Open
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/qt6-image-flip-compat
Open

fix: use QImage::flipped() for Qt6 compatibility#409
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/qt6-image-flip-compat

Conversation

@kt286

@kt286 kt286 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Replace QImage::mirrored() with QImage::flipped() when Qt version >= 6.0.0 to ensure compatibility with Qt6 API changes.

fix: 适配 Qt6 图像翻转 API

在 Qt6 中 QImage::mirrored() 已被 QImage::flipped() 替代, 添加版本检查以确保 Qt5 和 Qt6 的兼容性。

Summary by Sourcery

Support Qt 6 image flipping APIs while preserving compatibility with Qt 5.

Bug Fixes:

  • Maintain image flipping compatibility across Qt 5 and newer Qt 6 releases by selecting the appropriate QImage API.

Chores:

  • Update the copyright year range for the modified image handling code.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai

sourcery-ai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Reviewer's Guide

Ensure Qt5/Qt6 compatibility by conditionally using QImage::flipped() instead of QImage::mirrored() for image flipping operations and updating copyright years.

Flow diagram for Qt-version-compatible image flipping

flowchart TD
    A[Image flip requested] --> B{Qt version >= 6.0.0}
    B -->|Yes| C[QImage.flipped]
    B -->|No| D[QImage.mirrored]
    C --> E[Flipped QImage]
    D --> E
Loading

File-Level Changes

Change Details Files
Add Qt version-conditional image flipping to support Qt6 while preserving Qt5 behavior.
  • Wrap image flip calls in adjustImageToRealOrientation() with QT_VERSION checks and use QImage::flipped() in Qt6 builds for horizontal/vertical flips while retaining QImage::mirrored() for Qt5.
  • Update flipHorizontal() and flipVertical() helpers to use QImage::flipped() under Qt6 and QImage::mirrored() under Qt5.
  • Extend SPDX-FileCopyrightText year range to 2026.
src/util/dimagehandler.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@BLumia BLumia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

应该检查 6.9 而不是 6.0

Replace QImage::mirrored() with QImage::flipped() when Qt version >= 6.0.0
to ensure compatibility with Qt6 API changes.

fix: 适配 Qt6 图像翻转 API

在 Qt6 中 QImage::mirrored() 已被 QImage::flipped() 替代,
添加版本检查以确保 Qt5 和 Qt6 的兼容性。
@kt286
kt286 force-pushed the fix/qt6-image-flip-compat branch from fdcaa54 to 2655d9b Compare August 24, 2026 02:15
@kt286
kt286 requested a review from BLumia August 24, 2026 02:21
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia requested a review from 18202781743 August 24, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants