Repository navigation
include global metrics in updateMetrics for Flink Runner - #155
Merged
Merged
Conversation
yananhao12
changed the title
Zhangyx39
approved these changes
Dec 3, 2025
Zhangyx39
left a comment
Zhangyx39
left a comment
There was a problem hiding this comment.
LGTM. Thanks for porting this to flink.
| * results from the MetricsContainerStepMap. Instead of getting from all steps, it gets result | ||
| * from only interested steps. Thus, it's more efficient. | ||
| */ | ||
| private static MetricResults asAttemptedOnlyMetricResultsForSteps( |
There was a problem hiding this comment.
It may make sense to put this under MetricsContainerStepMap. Either place should be fine.
minxhe
approved these changes
Dec 3, 2025
|
would it be straight forward to fix these 2 tests? |
Author
Thanks for catching it. There seems to be some issue in the optimization method. I removed that part for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Metrics emission in non-processing thread is generally not supported in Beam.In Samza Runner, we added the support for Global Metrics which allow metrics emitted in non-processing thread to be collected through a global metrics container.
We want to add similar support for Global Metrics in Flink Runner. Currently a missing piece is that in the
updateMetricsstage, propagation of Beam metics into Flink metrics system is done by step/transform and does not include global metrics.Changes
This change ensures that metrics from
GLOBAL_METRICSstep are also propagated into Flink’s metric system.updateMetricsnow aggregates and queries metrics for both the per-step container and the global container, so global metrics become visible alongside step-specific metrics in Flink.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.