PineconeVectorStore(environment=...) is vestigial — deprecate & remove
PineconeVectorStore.__init__ (rag/stores/pinecone.py:59) accepts an environment param and documents it (:70) as "defaults to PINECONE_ENVIRONMENT env var," but the body (73-93) never reads it (nor any env var). Pinecone v3+ dropped the environment concept.
It's purely vestigial, but it's a public constructor parameter, so removing it is a breaking signature change — post-1.0 that needs a deprecation cycle.
Proposed path
- Now: fix the misleading docstring (say it's accepted-but-ignored / deprecated).
- Next minor: emit a
DeprecationWarning when environment is passed.
- A later minor (≥2 out): remove the param.
Acceptance
- Step 1 docstring fix can ship immediately (good first issue). Steps 2–3 follow the 1.0 deprecation policy.
PineconeVectorStore(environment=...)is vestigial — deprecate & removePineconeVectorStore.__init__(rag/stores/pinecone.py:59) accepts anenvironmentparam and documents it (:70) as "defaults to PINECONE_ENVIRONMENT env var," but the body (73-93) never reads it (nor any env var). Pinecone v3+ dropped theenvironmentconcept.It's purely vestigial, but it's a public constructor parameter, so removing it is a breaking signature change — post-1.0 that needs a deprecation cycle.
Proposed path
DeprecationWarningwhenenvironmentis passed.Acceptance