Fail closed when CLI compose walks segments.default instead of segments.all. (#168)

Bare compose now uses the same segments.all set as generate-all, so a mapped
02 missing visuals cannot hide behind a one-segment default list.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: jmjava

AGENTS.md

@@ -72,7 +72,7 @@ Commands registered on the **`docgen`** CLI include:
 - **`timestamps`** — word/segment timing (`timing.json`). Default engine **`local`** aligns the known narration text against the mp3 offline (ffmpeg silencedetect, no API); **`--engine whisper`** uses OpenAI whisper-1 or xAI `/v1/stt` when `ai.provider` is grok. Both emit the same Whisper-shaped blocks. Failed ffmpeg silencedetect raises `AlignmentError` (empty stderr is not treated as full-span speech). OpenAI whisper-1 word/segment `start`/`end` must be finite JSON numbers (bool/NaN raise `AIError`). Grok `/v1/stt` rejects empty word tokens and inverted `end < start` intervals (`AIError`). Empty ``segments.all`` raises ``TimestampError`` (same as TTS) and does not leave a stale ``timing.json`` as success.
 - **`image-generate`** — render scene-spec **image elements** (`image:` + `prompt:` boxes) via OpenAI Images or xAI Imagine into the bundle (also runs for missing assets inside `generate-all`).
 - **`manim`** — render Manim scenes declared in config.
-- **`compose`** — mux narration audio with visual sources via ffmpeg. A ``type: mixed`` row raises ``ComposeError`` if any listed source is missing (no silent subset mux).
+- **`compose`** — mux narration audio with visual sources via ffmpeg. With no segment ids, uses ``segments.all`` (same as ``generate-all``), not ``segments.default``. A ``type: mixed`` row raises ``ComposeError`` if any listed source is missing (no silent subset mux).
 - **`validate`** / **`validate --pre-push`** — drift, narration lint, Manim hints, **`timing_sync`**, **`story_end`** (last paced reveal vs audio end; hard fail), **`scene_assets`** (pre-render: stuck-board cadence, frame-budget overlaps, `MANIM_FONT` consistency, stale helpers / stale compiled class including hand-edited generated-region labels and `run_time` — hard fail; also a `generate-all` gate before Manim), **`av_sync`** (hard fail on `--pre-push` / `generate-all`; prefers scene-spec labels as OCR anchors), **`subject_beat_coverage`** (declarative specs vs narration topic beats; hard fail when enabled), and related visual-sync checks (`ocr_scan`, `layout`, `freeze_ratio` — hard fail on `--pre-push` / `generate-all`). Missing tesseract fails `ocr_scan` / `av_sync` / `layout` (not skip-PASS). Missing audio or an LFS pointer fails `timing_sync` and recording media gates (`stream_presence`, `av_drift`, `ocr_scan`, `av_sync`) (not skip-PASS). Missing `*.scene.yaml` fails `story_end` / `subject_beat_coverage` for `type: manim` (not skip-PASS).
 - **`lint`** — narration lint helper.
 - **`narration-generate`** — LLM-assisted narration from hints and repo context; optional **`--revise --revision-notes`** for in-place edits (same contract as the wizard Revise button).

README.md

@@ -243,7 +243,7 @@ docgen --repo /path/to/your-project generate-all
 | `docgen timestamps [--engine local\|whisper]` | Extract word/segment timestamps from TTS audio → `timing.json` (default `local`: offline narration-text alignment; `whisper`: OpenAI transcription). Empty `segments.all` is `TimestampError` (stale `timing.json` is not success) |
 | `docgen image-generate [--segment 01 \| --all \| --spec PATH] [--force] [--dry-run] [--model …] [--size …]` | Generate scene-spec image assets (`image:` + `prompt:` boxes) via the OpenAI Images API into the bundle |
 | `docgen manim [--scene StackDAGScene]` | Render Manim animations |
-| `docgen compose [01 02 03] [--ffmpeg-timeout 900]` | Compose segments (audio + video) |
+| `docgen compose [01 02 03] [--ffmpeg-timeout 900]` | Compose segments (audio + video). Omit ids to walk `segments.all` (same as `generate-all`); a mapped segment with missing audio/visuals is a hard fail |
 | `docgen validate [--max-drift 2.75] [--pre-push]` | Run all validation checks |
 | `docgen lint [--segment 01]` | Narration lint only |
 | `docgen concat [--config full-demo]` | Concatenate full demo files |

src/docgen/cli.py

@@ -486,13 +486,14 @@ def compose(
 ) -> None:
     """Compose segments (audio + video via ffmpeg).
 
-    Pass segment IDs to compose specific ones, or omit for the default set.
+    Pass segment IDs to compose specific ones, or omit for ``segments.all``
+    (same set as ``generate-all``).
     """
     from docgen.compose import ComposeError, Composer, filter_segments_by_visual_types
 
     cfg = _require_config(ctx)
     comp = Composer(cfg, ffmpeg_timeout_sec=ffmpeg_timeout)
-    target = list(segments) if segments else list(cfg.segments_default or cfg.segments_all)
+    target = list(segments) if segments else list(cfg.segments_all)
     target = filter_segments_by_visual_types(cfg, target, only_visual_types)
     if only_visual_types and not target:
         raise click.ClickException(
@@ -501,8 +502,7 @@ def compose(
         )
     if not target:
         raise click.ClickException(
-            "[compose] no segments to compose — set segments.default or "
-            "segments.all, or pass segment ids"
+            "[compose] no segments to compose — set segments.all, or pass segment ids"
         )
     click.echo(f"=== Composing {len(target)} segments ===")
     try:

tests/test_compose.py

@@ -213,6 +213,48 @@ def test_cli_compose_falls_back_to_segments_all_when_default_empty(tmp_path: Pat
     assert "Composing 1 segments" in result.output
 
 
+def test_cli_compose_uses_segments_all_not_default(tmp_path: Path, monkeypatch) -> None:
+    """Bare compose walks ``segments.all``, matching generate-all.
+
+    ``default: ["01"]`` plus ``all: ["01", "02"]`` must try both. With 01
+    muxable and 02 missing visuals, the CLI fail-closes on 1/2 instead of
+    exiting 0 after only the default set.
+    """
+    from click.testing import CliRunner
+
+    from docgen.cli import main
+    from docgen.compose import Composer
+
+    cfg = {
+        "dirs": {"animations": "animations", "audio": "audio", "recordings": "recordings"},
+        "segments": {"default": ["01"], "all": ["01", "02"]},
+        "segment_names": {"01": "01-demo", "02": "02-next"},
+        "visual_map": {
+            "01": {"type": "manim", "source": "Scene01.mp4"},
+            "02": {"type": "manim", "source": "Scene02.mp4"},
+        },
+        "manim": {"quality": "1080p30"},
+    }
+    c = _write_cfg(tmp_path, cfg)
+    audio_dir = tmp_path / "audio"
+    audio_dir.mkdir(parents=True, exist_ok=True)
+    (audio_dir / "01-demo.mp3").write_bytes(b"audio")
+    video_dir = tmp_path / "animations" / "media" / "videos" / "scenes" / "1080p30"
+    video_dir.mkdir(parents=True, exist_ok=True)
+    (video_dir / "Scene01.mp4").write_bytes(b"video")
+    (tmp_path / "recordings").mkdir(parents=True, exist_ok=True)
+    monkeypatch.setattr(Composer, "_probe_duration", lambda self, _p: 10.0)
+    monkeypatch.setattr(Composer, "_run_ffmpeg", lambda self, _cmd: None)
+
+    runner = CliRunner()
+    result = runner.invoke(main, ["--config", str(c.yaml_path), "compose"])
+    combined = result.output + result.stderr
+    assert result.exit_code != 0
+    assert "Composing 2 segments" in combined
+    assert "1/2" in combined
+    assert "02" in combined
+
+
 def test_cli_lint_exits_nonzero_when_narration_missing(tmp_path: Path) -> None:
     from click.testing import CliRunner