Skip to content

Commit d2fa472

Browse files
authored
feat!: remove deprecated mount-pnpm-store feature (#5)
Superseded by shared-pnpm-store.
1 parent ada268a commit d2fa472

19 files changed

Lines changed: 10 additions & 495 deletions

File tree

‎.github/workflows/test.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ jobs:
1313
matrix:
1414
features:
1515
- shared-pnpm-store
16-
- mount-pnpm-store
1716
baseImage:
1817
- debian:latest
1918
- ubuntu:latest
@@ -33,7 +32,6 @@ jobs:
3332
matrix:
3433
features:
3534
- shared-pnpm-store
36-
- mount-pnpm-store
3735
steps:
3836
- uses: actions/checkout@v4
3937

‎LICENSE‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
MIT License
22

33
Copyright (c) 2026 ITplusX
4-
Portions Copyright (c) 2023 Joshua Ji
5-
(src/mount-pnpm-store, copied from https://github.com/joshuanianji/devcontainer-features)
64

75
Permission is hereby granted, free of charge, to any person obtaining a copy
86
of this software and associated documentation files (the "Software"), to deal

‎README.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ Custom [Dev Container Features](https://containers.dev/implementors/features/) m
66

77
| Feature | Description |
88
| ------- | ----------- |
9-
| [`shared-pnpm-store`](./src/shared-pnpm-store) | Mounts a shared Docker volume as the pnpm store directory via `containerEnv`. Never invokes pnpm. **Recommended.** |
10-
| [`mount-pnpm-store`](./src/mount-pnpm-store) | **Deprecated** — use `shared-pnpm-store` instead. Sets the pnpm store to `~/.pnpm-store` and mounts it to a shared volume. Patched copy of [joshuanianji/devcontainer-features](https://github.com/joshuanianji/devcontainer-features) that works with pnpm >= 9 in non-interactive lifecycle shells. |
9+
| [`shared-pnpm-store`](./src/shared-pnpm-store) | Mounts a shared Docker volume as the pnpm store directory via `containerEnv`. Never invokes pnpm. |
10+
11+
> The former `mount-pnpm-store` feature has been removed. Use `shared-pnpm-store` instead.
1112
1213
## Usage
1314

@@ -45,4 +46,4 @@ The initial implementation of `shared-pnpm-store` was developed locally by [@sch
4546

4647
## License
4748

48-
MIT — see [LICENSE](./LICENSE). The `mount-pnpm-store` feature contains code Copyright (c) 2023 Joshua Ji (MIT).
49+
MIT — see [LICENSE](./LICENSE).

‎src/mount-pnpm-store/NOTES.md‎

Lines changed: 0 additions & 96 deletions
This file was deleted.

‎src/mount-pnpm-store/README.md‎

Lines changed: 0 additions & 120 deletions
This file was deleted.

‎src/mount-pnpm-store/devcontainer-feature.json‎

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎src/mount-pnpm-store/install.sh‎

Lines changed: 0 additions & 52 deletions
This file was deleted.

‎src/mount-pnpm-store/oncreate.sh‎

Lines changed: 0 additions & 27 deletions
This file was deleted.

‎src/shared-pnpm-store/NOTES.md‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ It does this with four declarative pieces and **no pnpm invocation**:
1919
non-root user on every container create.
2020

2121
Because pnpm is never invoked, this feature avoids the `pnpm config set --global`
22-
/ `PNPM_HOME` / PATH / non-interactive-shell problems that `mount-pnpm-store` has
23-
to patch. It is a simpler alternative; the two features are independent.
22+
/ `PNPM_HOME` / PATH / non-interactive-shell problems that arise when a feature
23+
has to configure pnpm from a non-interactive lifecycle shell.
2424

2525
## Ownership of the shared store
2626

@@ -56,9 +56,7 @@ depend on the interactive shell)
5656
## Volume Mount Naming
5757

5858
The volume is named `devcontainer-shared-pnpm-store`. Ensure no other Docker
59-
volume collides with this name. (This is a different volume from
60-
`mount-pnpm-store`'s `global-devcontainer-pnpm-store`, so the two features do
61-
not share a store with each other.)
59+
volume collides with this name.
6260

6361
## Changelog
6462

0 commit comments

Comments
 (0)