Skip to content

igraphmodule_Graph_dominator always boxes returned ints and doesn't expose all C function outputs #853

@dcolascione

Description

@dcolascione

Describe the bug

The igraphmodule_Graph_dominator shouldn't box its return values in Python ints. I generally prefer to use graph libraries in such a way that there's no direct relationship between the size of my data set and the number of Python heap objects I have to allocate. Additionally, the underlying C function is capable of returning three outputs (a graph and a list of nodes left out), and the Python binding ignores all of them except the dominator list.

Expected behavior

The function should have a parameter that asks it to return some kind of Python-buffer-protocol-supporting object allowing for batch extraction of the dominator list.

Current behavior

Returns list[int]

Version information

Mainline.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions