Skip to content

Off-site review links without http(s) prefix are broken #1391

Description

@salty-horse

About 1% of off-site review links are missing a prefix protocol, and are then rendered as internal to the IFDB domain: https://ifdb.org/example.com.

select gameid, reviewid, sourceurl from extreviews where sourceurl is not null and sourceurl not like 'http%';

(57 rows)

The PHP code should probably add http:// if it's missing, but there should be some validation on the form to force users to enter a full protocol.

However, it's not a good idea to force that validation when the user is just editing a game with an existing broken external link.

Related bug: #617 (Automated link checking of off-site review links), but that one's more about making an HTTP request to check if the website is still alive.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions