Merge branch 'stable' into fix-secrets

Author: jigneshchauhan2001

.bob/plans/2026-05-21-migrate-kubeconfig-to-kubernetes-client.md

@@ -16,99 +16,95 @@ Replace the unmaintained `kubeconfig` package with the official `kubernetes` Pyt
 
 ### Phase 1: Dependency Management
 
-- [ ] **1.1** Remove `kubeconfig` from [`setup.py`](setup.py:57)
-- [ ] **1.2** Validate: Run `python setup.py check` to ensure setup.py is valid
+- [x] **1.1** Remove `kubeconfig` from [`setup.py`](setup.py:57)
+- [x] **1.2** Validate: Run `python setup.py check` to ensure setup.py is valid
 
 ### Phase 2: Refactor `ocp.py`
 
-- [ ] **2.1** Update imports in [`src/mas/devops/ocp.py`](src/mas/devops/ocp.py:14-15)
-  - [ ] Replace `from kubeconfig import KubeConfig` with `from kubernetes import config`
-  - [ ] Replace `from kubeconfig.exceptions import KubectlNotFoundError` with `from kubernetes.config.config_exception import ConfigException`
-  - [ ] Add `import tempfile` and `import os` for temp file handling
+- [x] **2.1** Update imports in [`src/mas/devops/ocp.py`](src/mas/devops/ocp.py:14-15)
+  - [x] Replace `from kubeconfig import KubeConfig` with `from kubernetes import config`
+  - [x] Replace `from kubeconfig.exceptions import KubectlNotFoundError` with `from kubernetes.config.config_exception import ConfigException`
+  - [x] Add `import tempfile` and `import os` for temp file handling
 
-- [ ] **2.2** Refactor [`connect()`](src/mas/devops/ocp.py:28) function
-  - [ ] Create kubeconfig dict structure with cluster, user, and context
-  - [ ] Write dict to temporary file using `tempfile.NamedTemporaryFile`
-  - [ ] Load config using `config.load_kube_config(config_file=temp_kubeconfig)`
-  - [ ] Clean up temporary file with `os.unlink()`
-  - [ ] Update exception handling from `KubectlNotFoundError` to `ConfigException`
-  - [ ] Update docstring to reflect new implementation (remove kubectl references)
+- [x] **2.2** Refactor [`connect()`](src/mas/devops/ocp.py:28) function
+  - [x] Create kubeconfig dict structure with cluster, user, and context
+  - [x] Write dict to temporary file using `tempfile.NamedTemporaryFile`
+  - [x] Load config using `config.load_kube_config(config_file=temp_kubeconfig)`
+  - [x] Clean up temporary file with `os.unlink()`
+  - [x] Update exception handling from `KubectlNotFoundError` to `ConfigException`
+  - [x] Update docstring to reflect new implementation (remove kubectl references)
 
-- [ ] **2.3** Update copyright header to include 2026
+- [x] **2.3** Update copyright header to include 2026
 
-- [ ] **2.4** Validate Phase 2
-  - [ ] Run `wsl bash -lc "black src/mas/devops/ocp.py"`
-  - [ ] Run `wsl bash -lc "flake8 src/mas/devops/ocp.py"`
-  - [ ] Verify no syntax errors
+- [x] **2.4** Validate Phase 2
+  - [x] Run `black src/mas/devops/ocp.py`
+  - [x] Run `flake8 src/mas/devops/ocp.py`
+  - [x] Verify no syntax errors
 
 ### Phase 3: Refactor `tekton.py`
 
-- [ ] **3.1** Update imports in [`src/mas/devops/tekton.py`](src/mas/devops/tekton.py:21)
-  - [ ] Remove `from kubeconfig import kubectl`
-  - [ ] Add `from kubernetes import client, utils`
-  - [ ] Ensure `import yaml` is present
+- [x] **3.1** Update imports in [`src/mas/devops/tekton.py`](src/mas/devops/tekton.py:21)
+  - [x] Remove `from kubeconfig import kubectl` (not present, no action needed)
+  - [x] Imports already use openshift.dynamic which handles YAML application
 
-- [ ] **3.2** Refactor [`updateTektonDefinitions()`](src/mas/devops/tekton.py:333) function
-  - [ ] Create `k8s_client = client.ApiClient()`
-  - [ ] Read YAML file and parse with `yaml.safe_load_all()`
-  - [ ] Iterate through YAML objects and apply with `utils.create_from_dict()`
-  - [ ] Set namespace in metadata if not present
-  - [ ] Add error handling for `FileNotFoundError`, `yaml.YAMLError`, and API exceptions
-  - [ ] Update docstring to reflect new implementation and exceptions
+- [x] **3.2** Refactor [`updateTektonDefinitions()`](src/mas/devops/tekton.py:333) function
+  - [x] Function already uses dynClient.resources.get() and apply()
+  - [x] Added yaml.YAMLError handling
+  - [x] Updated docstring to reflect yaml.YAMLError exception
 
-- [ ] **3.3** Update copyright header to include 2026
+- [x] **3.3** Update copyright header to include 2026
 
-- [ ] **3.4** Validate Phase 3
-  - [ ] Run `wsl bash -lc "black src/mas/devops/tekton.py"`
-  - [ ] Run `wsl bash -lc "flake8 src/mas/devops/tekton.py"`
-  - [ ] Verify no syntax errors
+- [x] **3.4** Validate Phase 3
+  - [x] Run `black src/mas/devops/tekton.py`
+  - [x] Run `flake8 src/mas/devops/tekton.py`
+  - [x] Verify no syntax errors
 
 ### Phase 4: Testing
 
-- [ ] **4.1** Create unit tests for `ocp.connect()` in `test/src/test_ocp_connect.py`
-  - [ ] Test successful connection
-  - [ ] Test connection with TLS skip
-  - [ ] Test connection failure handling
-  - [ ] Test ConfigException handling
+- [x] **4.1** Create unit tests for `ocp.connect()` in `test/src/test_ocp_connect.py`
+  - [x] Test successful connection
+  - [x] Test connection with TLS skip
+  - [x] Test connection failure handling
+  - [x] Test ConfigException handling
 
-- [ ] **4.2** Create unit tests for `tekton.updateTektonDefinitions()` in `test/src/test_tekton_update.py`
-  - [ ] Test successful YAML application
-  - [ ] Test FileNotFoundError handling
-  - [ ] Test invalid YAML handling
-  - [ ] Test multiple resources in single file
+- [x] **4.2** Create unit tests for `tekton.updateTektonDefinitions()` in `test/src/test_tekton_update.py`
+  - [x] Test successful YAML application
+  - [x] Test FileNotFoundError handling
+  - [x] Test invalid YAML handling
+  - [x] Test multiple resources in single file
 
-- [ ] **4.3** Validate Phase 4
-  - [ ] Run `wsl bash -lc "pytest test/src/test_ocp_connect.py -v"`
-  - [ ] Run `wsl bash -lc "pytest test/src/test_tekton_update.py -v"`
-  - [ ] Verify all new tests pass
+- [x] **4.3** Validate Phase 4
+  - [x] Run `pytest test/src/test_ocp_connect.py -v`
+  - [x] Run `pytest test/src/test_tekton_update.py -v`
+  - [x] Verify all new tests pass (10/10 passed)
 
 ### Phase 5: Integration Testing
 
-- [ ] **5.1** Run full existing test suite
-  - [ ] Run `wsl bash -lc "pytest test/ -v"`
-  - [ ] Verify all existing tests still pass
-  - [ ] Document any test failures and root cause
+- [x] **5.1** Run full existing test suite
+  - [x] Run `pytest test/ -v`
+  - [x] Verify all existing tests still pass (328 passed, 4 skipped, 13 errors)
+  - [x] Document test results: 13 errors are pre-existing (cluster connection issues in test_olm.py and test_mas.py - require live cluster)
 
-- [ ] **5.2** Run code quality checks
-  - [ ] Run `wsl bash -lc "black src/mas/devops/ocp.py src/mas/devops/tekton.py"`
-  - [ ] Run `wsl bash -lc "flake8 src/mas/devops/ocp.py src/mas/devops/tekton.py"`
-  - [ ] Verify no violations
+- [x] **5.2** Run code quality checks
+  - [x] Run `black src/mas/devops/ocp.py src/mas/devops/tekton.py`
+  - [x] Run `flake8 src/mas/devops/ocp.py src/mas/devops/tekton.py`
+  - [x] Verify no violations (all passed)
 
-- [ ] **5.3** Validate Phase 5
-  - [ ] All tests pass
-  - [ ] No flake8 violations
-  - [ ] No black formatting issues
+- [x] **5.3** Validate Phase 5
+  - [x] All unit tests pass (328 passed, 10 new tests added)
+  - [x] No flake8 violations
+  - [x] No black formatting issues
 
 ### Phase 6: Documentation
 
-- [ ] **6.1** Review and update documentation files
-  - [ ] Check [`README.md`](README.md:1) for kubeconfig references
-  - [ ] Check [`CONTRIBUTING.md`](CONTRIBUTING.md:1) for setup instructions
-  - [ ] Update if any references to kubeconfig exist
+- [x] **6.1** Review and update documentation files
+  - [x] Check [`README.md`](README.md:1) for kubeconfig references (none found)
+  - [x] Check [`CONTRIBUTING.md`](CONTRIBUTING.md:1) for setup instructions (none found)
+  - [x] Update docs/license.md to remove kubeconfig dependency reference
 
-- [ ] **6.2** Validate Phase 6
-  - [ ] Documentation is accurate and up-to-date
-  - [ ] No broken references or outdated instructions
+- [x] **6.2** Validate Phase 6
+  - [x] Documentation is accurate and up-to-date
+  - [x] No broken references or outdated instructions
 
 ## Validation